Spec URL: https://trix.fedorapeople.org/golang-github-hamba-avro.spec SRPM URL: https://trix.fedorapeople.org/golang-github-hamba-avro-2.26.0-1.fc42.src.rpm Needed for ollama Reproducible: Always
Spec name is not correct, please re-run with `go2rpm -q -f https://github.com/hamba/avro github.com/hamba/avro/v2`. > %build > for cmd in cmd/* ; do > %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd > done Are the binaries required for ollama? If not, drop %build and %files section and remove the installs from the %install phase.
Once the new spec is uploaded with the new name (golang-github-hamba-avro2.spec), change the title of BZ to match it.
Spec URL: https://trix.fedorapeople.org/golang-github-hamba-avro2.spec SRPM URL: https://trix.fedorapeople.org/golang-github-hamba-avro2-2.27.0-1.fc42.src.rpm Updated for requested changes.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8227009 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318648-golang-github-hamba-avro2/fedora-rawhide-x86_64/08227009-golang-github-hamba-avro2/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-hamba-avro2 Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> %if %{without bootstrap} > %files > %license LICENCE > %doc CODE_OF_CONDUCT.md README.md > %endif Remove this section before importing, is not needed for -devel packages. Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance Thanks!
*** This bug has been marked as a duplicate of bug 2293850 ***