Bug 2294380

Summary:	Review Request: openjpeg - C-Library for JPEG 2000
Product:	[Fedora] Fedora	Reporter:	Sandro Mani <manisandro>
Component:	Package Review	Assignee:	Sergio Basto <sergio>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, sergio, trawets
Target Milestone:	---	Flags:	sergio: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/uclouvain/openjpeg
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-17 23:11:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sandro Mani 2024-06-26 09:26:53 UTC

Spec URL: https://smani.fedorapeople.org/review/openjpeg.spec
SRPM URL: https://smani.fedorapeople.org/review/openjpeg-2.5.2-2.fc41.src.rpm
Description: C-Library for JPEG 2000
Fedora Account System Username: smani

Scratch build: C-Library for JPEG 2000

This is a re-review to rename the package from openjpeg2 to openjpeg.

Comment 1 Fedora Review Service 2024-06-26 09:48:14 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7671029
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294380-openjpeg/fedora-rawhide-x86_64/07671029-openjpeg/fedora-review/review.txt

Found issues:

- mingw32-openjpeg : /usr/i686-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/openjpeg.h mingw32-openjpeg : /usr/i686-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/opj_config.h mingw64-openjpeg : /usr/x86_64-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/openjpeg.h mingw64-openjpeg : /usr/x86_64-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/opj_config.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/openjpeg
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Package has .a files: mingw32-openjpeg, mingw64-openjpeg. Illegal package name: mingw32-openjpeg, mingw64-openjpeg. Does not provide -static: mingw32-openjpeg, mingw64-openjpeg.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries
- Documentation size is 13807907 bytes in 521 files. 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Sergio Basto 2024-06-26 11:43:03 UTC

(In reply to Fedora Review Service from comment #1)


> - Documentation size is 13807907 bytes in 521 files. 
>   Read more:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

the spec is almost equal to openjpeg2 , without all renames to avoid avoid conflicts with openjpeg-1.x , which is good  . 

I just find documentation in devel-docs package which is correct . Maybe I call this sub-package as doc only, instead devel-doc but is not important, neither I'm sure that is the correct. 

Package APPROVED

Comment 3 Sandro Mani 2024-06-26 11:46:34 UTC

Thanks, unretirement of openjpeg requested at https://pagure.io/releng/issue/12179

Comment 4 Sandro Mani 2024-06-26 12:01:09 UTC

Since I acutally don't maintain the native openjpeg, I guess the proper way forward is for @trawets or @rdieter to update the package with this spec, resp add me as package admin if they're happy with me taking over.