Bug 2294579
| Summary: | Review Request: rust-cli-table-derive - For printing tables on command line | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | wojnilowicz <lukasz.wojnilowicz> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | lukasz.wojnilowicz, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | lukasz.wojnilowicz:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/cli-table-derive | ||
| Whiteboard: | |||
| Fixed In Version: | rust-cli-table-derive-0.4.6-1.fc42 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-08-25 16:32:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2294577 | ||
|
Description
Fabio Valentini
2024-06-27 12:18:13 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=119690993 Copr build: https://copr.fedorainfracloud.org/coprs/build/7676566 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294579-rust-cli-table-derive/fedora-rawhide-x86_64/07676566-rust-cli-table-derive/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. LGTM, but could you switch to 0.4.6? 0.4.5 is no longer the latest. Thank you for the review! Spec URL: https://decathorpe.fedorapeople.org/rust-cli-table-derive.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-cli-table-derive-0.4.6-1.fc40.src.rpm Can you take another look please? Package was generated with rust2rpm, simplifying the review. ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Thank you for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cli-table-derive |