Bug 2294579 - Review Request: rust-cli-table-derive - For printing tables on command line
Summary: Review Request: rust-cli-table-derive - For printing tables on command line
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cli-table-de...
Whiteboard:
Depends On:
Blocks: 2294577
TreeView+ depends on / blocked
 
Reported: 2024-06-27 12:18 UTC by Fabio Valentini
Modified: 2024-08-25 16:32 UTC (History)
2 users (show)

Fixed In Version: rust-cli-table-derive-0.4.6-1.fc42
Clone Of:
Environment:
Last Closed: 2024-08-25 16:32:37 UTC
Type: ---
Embargoed:
lukasz.wojnilowicz: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-06-27 12:18:13 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-cli-table-derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cli-table-derive-0.4.5-1.fc40.src.rpm

Description:
A crate for printing tables on command line.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-06-27 12:18:15 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=119690993

Comment 2 Fedora Review Service 2024-06-27 12:24:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7676566
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294579-rust-cli-table-derive/fedora-rawhide-x86_64/07676566-rust-cli-table-derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 wojnilowicz 2024-07-14 15:33:37 UTC
LGTM, but could you switch to 0.4.6? 0.4.5 is no longer the latest.

Comment 4 Fabio Valentini 2024-07-16 11:20:57 UTC
Thank you for the review!

Comment 6 Fabio Valentini 2024-08-05 17:39:18 UTC
Can you take another look please?

Comment 7 wojnilowicz 2024-08-05 17:55:19 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment 8 Fabio Valentini 2024-08-25 15:42:51 UTC
Thank you for the review!

Comment 9 Fedora Admin user for bugzilla script actions 2024-08-25 15:43:33 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cli-table-derive


Note You need to log in before you can comment on or make changes to this bug.