Bug 2294816

Summary: Review Request: rust-if_chain - Macro for writing nested if let expressions
Product: [Fedora] Fedora Reporter: Benjamin Gilbert <bgilbert>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/if_chain
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-03 22:26:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2295731    

Description Benjamin Gilbert 2024-06-30 14:48:04 UTC
Spec URL: https://fedorapeople.org/~bgilbert/srpm/rust-if_chain.spec
SRPM URL: https://fedorapeople.org/~bgilbert/srpm/rust-if_chain-1.0.2-1.fc40.src.rpm
Description: Macro for writing nested if let expressions
Fedora Account System Username: bgilbert

Comment 1 Fedora Review Service 2024-06-30 14:53:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7693396
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294816-rust-if_chain/fedora-rawhide-x86_64/07693396-rust-if_chain/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-03 16:23:21 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have time, it would be great if you could review any pending Rust package in return.

Comment 3 Benjamin Gilbert 2024-07-03 21:44:50 UTC
The Pagure repository was created (after some hiccups) at https://src.fedoraproject.org/rpms/rust-if_chain

Comment 4 Fedora Update System 2024-07-03 22:23:56 UTC
FEDORA-2024-8003dffae4 (rust-if_chain-1.0.2-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8003dffae4

Comment 5 Fedora Update System 2024-07-03 22:26:27 UTC
FEDORA-2024-8003dffae4 (rust-if_chain-1.0.2-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.