Spec URL: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool.spec SRPM URL: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool-2.4.1-1.fc40.src.rpm Description: Full-featured terminal-based sequence editor for Git interactive rebase. Fedora Account System Username: bgilbert
rust2rpm.toml for this specfile: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool-rust2rpm.toml
Copr build: https://copr.fedorainfracloud.org/coprs/build/7706212 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295731-rust-git-interactive-rebase-tool/fedora-rawhide-x86_64/07706212-rust-git-interactive-rebase-tool/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
captur, claims, if_chain, and version-track are in Rawhide now but apparently haven't been pushed to the mirrors yet.
It looks like it would be easier to package this from the GitHug sources since the published crate is missing some files? You could use the GitHub sources if you drop the rust- prefix for the package name. rust2rpm supports generating spec files like this - just point it at an unpacked ./Cargo.toml path instead of supplying a crate name.
I've submitted upstream PRs to address the rough spots in the packaging. I'm hoping those will land and the specfile can then straightforwardly package the crate. However, upstream hasn't yet indicated its inclination to accept or reject those changes.
Upstream is willing to accept the changes [1] so I'd like to proceed with a crate-style package. Everything in rust2rpm.toml except `package.extra-files` and `scripts.install` should go away after the next release. [1]: https://github.com/MitMaro/git-interactive-rebase-tool/pull/931#issuecomment-2209444927
[fedora-review-service-build]
Spec URL: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool.spec SRPM URL: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool-2.4.1-1.fc40.src.rpm
Looks good to me, with two exceptions: > %{__install} -p src/interactive-rebase-tool.1 -t %{buildroot}%{_mandir}/man1 -D -m 644 Please don't use macros prefixed by two underscores like %__install. They are RPM internals. Use plain "install" instead. > You should have received a copy of the GNU General Public License > along with this program. If not, see <https://www.gnu.org/licenses/>. It's a bit funny that this is included in the LICENSE file ... The project doesn't actually include the GPL-3.0 license text, as far as I can tell. Please ask upstream to actually include the full license text too.
Thanks for the review! > Please don't use macros prefixed by two underscores like %__install. They are RPM internals. Use plain "install" instead. Fixed. > It's a bit funny that this is included in the LICENSE file ... > The project doesn't actually include the GPL-3.0 license text, as far as I can tell. > Please ask upstream to actually include the full license text too. Good catch! PR in https://github.com/MitMaro/git-interactive-rebase-tool/pull/933, and I've updated the package to paste in a COPYING file for now. Spec URL: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool.spec SRPM URL: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool-2.4.1-1.fc40.src.rpm rust2rpm.toml: https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool-rust2rpm.toml
Thanks! I would like to give upstream time to respond to your pull request If there is no timely response, we can continue here with the manually added license text according to https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
Sounds good! [fedora-review-service-build]
The PR has been merged upstream.
This no longer builds in rawhide because you pushed version-track 1.0.0: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a0e276817 This package still requires v0.1.0.
Updated.
Fabio, could you take another look?
Looks good to me. Hopefully there will be another release upstream soon so that most of the manual sources / patches can be dropped. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license file is included with %license in %files (manually included from upstream) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-git-interactive-rebase-tool
FEDORA-2024-bc3de1488f (rust-git-interactive-rebase-tool-2.4.1-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-bc3de1488f
FEDORA-2024-bc3de1488f (rust-git-interactive-rebase-tool-2.4.1-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-da34aec1b8 (rust-git-interactive-rebase-tool-2.4.1-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-da34aec1b8
FEDORA-2024-da34aec1b8 (rust-git-interactive-rebase-tool-2.4.1-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.