Bug 2295136 (rust-cidr-utils)

Summary: Review Request: rust-cidr-utils - Functions for working with IPv4 CIDRs and IPv6 CIDRs
Product: [Fedora] Fedora Reporter: Paul Pfeister <redhat>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/cidr-utils
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-13 23:06:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2295134    
Bug Blocks: 2295139    

Description Paul Pfeister 2024-07-02 07:12:51 UTC
Spec URL: https://raw.githubusercontent.com/ppfeister/pkg/master/rust-cidr-utils.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora-rawhide-x86_64/07697617-rust-cidr-utils/rust-cidr-utils-0.6.1-1.fc41.src.rpm

Description: This library provides functions for working with IPv4 CIDRs and IPv6 CIDRs.

Fedora Account System Username: ppfeister

Please confirm that I have handled extras correctly.
This is blocked by rust-cidr. All blockers included in copr ppfeister/RustScan with reviews (successful build when met).

Comment 1 Fedora Review Service 2024-07-02 07:15:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7697790
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295136-rust-cidr-utils/fedora-rawhide-x86_64/07697790-rust-cidr-utils/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Paul Pfeister 2024-07-05 18:50:45 UTC
Curious if this will work despite the report on rust-cidr..... [fedora-review-service-build]

Comment 3 Paul Pfeister 2024-07-06 07:06:15 UTC
[fedora-review-service-build]

Comment 4 Paul Pfeister 2024-07-08 00:03:21 UTC
It seems the review service is back online now, so let's try this again: [fedora-review-service-build]

Comment 5 Paul Pfeister 2024-07-09 20:52:20 UTC
Third time is the charm, right? [fedora-review-service-build]

Comment 6 Fedora Review Service 2024-07-09 21:12:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7720751
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295136-rust-cidr-utils/fedora-rawhide-x86_64/07720751-rust-cidr-utils/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fabio Valentini 2024-07-13 18:46:21 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fedora Admin user for bugzilla script actions 2024-07-13 22:33:46 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cidr-utils

Comment 9 Fedora Update System 2024-07-13 23:01:40 UTC
FEDORA-2024-4fccd3ee4f (rust-cidr-utils-0.6.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4fccd3ee4f

Comment 10 Fedora Update System 2024-07-13 23:06:26 UTC
FEDORA-2024-4fccd3ee4f (rust-cidr-utils-0.6.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.