Spec URL: https://raw.githubusercontent.com/ppfeister/pkg/master/rust-cidr.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora-rawhide-x86_64/07697726-rust-cidr/rust-cidr-0.2.3-1.fc41.src.rpm Description: This library provides types to represent an IP network (Cidr) or an IP host withing a network (Inet) Fedora Account System Username: ppfeister Please confirm that I have handled extras correctly.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7697772 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295134-rust-cidr/fedora-rawhide-x86_64/07697772-rust-cidr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Can you clarify what you mean by "extras"? That term doesn't mean anything wrt/ Rust packages. However, package looks good to me. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cidr
"extras" meaning +xyz such as in this case, rust-cidr+bitstring-devel But it seems like we're good to go with those! Created according to recommended tasks. Thanks for review!
FEDORA-2024-ad7671890f (rust-cidr-0.2.3-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ad7671890f
FEDORA-2024-ad7671890f (rust-cidr-0.2.3-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
Sorry - looks like I messed up the check for the package installability. Not sure how ... but I see you already opened a review request for the "bitstring" crate.
The fact that bitstring an _optional_ (and unused) dependency is what screwed up my own testing. This is something that I've added to my _list of things to look out for_ in later packages.