Bug 2295138 (rust-text_placeholder)
| Summary: | Review Request: rust-text_placeholder - Minimalistic text template engine designed for the manipulation of named placeholders | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Pfeister <redhat> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/text_placeholder | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-07-05 20:08:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2295139 | ||||||
| Attachments: |
|
||||||
|
Description
Paul Pfeister
2024-07-02 07:20:47 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7697801 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295138-rust-text_placeholder/fedora-rawhide-x86_64/07697801-rust-text_placeholder/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > # FIXME: no license files detected
This auto-generated FIXME is indeed correct.
Both the MIT and Apache-2.0 licenses require that redistributed sources contain a copy of the license text. Please open a ticket with the upstream project. They should include license texts for Apache-2.0 and MIT and make sure they are included in published .crate files.
Good critique. I shouldn't work on packages at 3am. Upstream contacted and issue raised. Will update ticket once addressed. Upstream added MIT to source and republished crate. Should be GTG. SRPM URL: https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora-rawhide-x86_64/07705461-rust-text_placeholder/rust-text_placeholder-0.5.1-1.fc41.src.rpm SPEC URL: https://raw.githubusercontent.com/ppfeister/pkg/master/rust-text_placeholder.spec Created attachment 2038939 [details]
The .spec file difference from Copr build 7697801 to 7705464
Copr build: https://copr.fedorainfracloud.org/coprs/build/7705464 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295138-rust-text_placeholder/fedora-rawhide-x86_64/07705464-rust-text_placeholder/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-text_placeholder FEDORA-2024-cd4ecb83cb (rust-text_placeholder-0.5.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-cd4ecb83cb FEDORA-2024-cd4ecb83cb (rust-text_placeholder-0.5.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |