Bug 2295138 (rust-text_placeholder) - Review Request: rust-text_placeholder - Minimalistic text template engine designed for the manipulation of named placeholders
Summary: Review Request: rust-text_placeholder - Minimalistic text template engine des...
Keywords:
Status: CLOSED ERRATA
Alias: rust-text_placeholder
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/text_placeho...
Whiteboard:
Depends On:
Blocks: rustscan
TreeView+ depends on / blocked
 
Reported: 2024-07-02 07:20 UTC by Paul Pfeister
Modified: 2024-08-12 04:24 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-05 20:08:31 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7697801 to 7705464 (678 bytes, patch)
2024-07-03 22:01 UTC, Fedora Review Service
no flags Details | Diff

Description Paul Pfeister 2024-07-02 07:20:47 UTC
Spec URL: https://raw.githubusercontent.com/ppfeister/pkg/master/rust-text_placeholder.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora-rawhide-x86_64/07697727-rust-text_placeholder/rust-text_placeholder-0.5.0-1.fc41.src.rpm

Description: Text Placeholder is a minimalistic text template engine designed for the manipulation of named placeholders within textual templates.

Fedora Account System Username: ppfeister

Please confirm that I have handled extras correctly. Not 100% on that portion of it.

Comment 1 Fedora Review Service 2024-07-02 07:33:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7697801
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295138-rust-text_placeholder/fedora-rawhide-x86_64/07697801-rust-text_placeholder/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-03 17:29:28 UTC
> # FIXME: no license files detected

This auto-generated FIXME is indeed correct.

Both the MIT and Apache-2.0 licenses require that redistributed sources contain a copy of the license text. Please open a ticket with the upstream project. They should include license texts for Apache-2.0 and MIT and make sure they are included in published .crate files.

Comment 3 Paul Pfeister 2024-07-03 19:28:46 UTC
Good critique. I shouldn't work on packages at 3am.

Upstream contacted and issue raised. Will update ticket once addressed.

Comment 5 Fedora Review Service 2024-07-03 22:01:01 UTC
Created attachment 2038939 [details]
The .spec file difference from Copr build 7697801 to 7705464

Comment 6 Fedora Review Service 2024-07-03 22:01:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7705464
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295138-rust-text_placeholder/fedora-rawhide-x86_64/07705464-rust-text_placeholder/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fabio Valentini 2024-07-05 17:37:40 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fedora Admin user for bugzilla script actions 2024-07-05 18:36:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-text_placeholder

Comment 9 Fedora Update System 2024-07-05 18:47:19 UTC
FEDORA-2024-cd4ecb83cb (rust-text_placeholder-0.5.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cd4ecb83cb

Comment 10 Fedora Update System 2024-07-05 20:08:31 UTC
FEDORA-2024-cd4ecb83cb (rust-text_placeholder-0.5.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.