Bug 2295139 (rustscan)
| Summary: | Review Request: rustscan - Modern port scanner | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Pfeister <redhat> | ||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/rustscan/rustscan | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2295136, 2295138 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Paul Pfeister
2024-07-02 07:31:26 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7697831 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295139-rustscan/fedora-rawhide-x86_64/07697831-rustscan/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. copr rebuilt with changes (build here will still fail due to linked dependencies) https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora-rawhide-x86_64/07699320-rustscan/rustscan-2.2.3-1.fc41.src.rpm Created attachment 2038723 [details]
The .spec file difference from Copr build 7697831 to 7699385
Copr build: https://copr.fedorainfracloud.org/coprs/build/7699385 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295139-rustscan/fedora-rawhide-x86_64/07699385-rustscan/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Blockers cleared on Rawhide [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/7732385 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295139-rustscan/fedora-rawhide-x86_64/07732385-rustscan/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Probably using the old srpm still. Build actually succeeds. New links: SRPM: https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora-rawhide-x86_64/07732394-rustscan/rustscan-2.3.0-1.fc41.src.rpm Spec: https://github.com/ppfeister/rustscan-fedora.git Created attachment 2039582 [details]
The .spec file difference from Copr build 7732385 to 7732647
Copr build: https://copr.fedorainfracloud.org/coprs/build/7732647 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295139-rustscan/fedora-rawhide-x86_64/07732647-rustscan/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Whiteboarded as pending a fix, but it actually seems to be correct and ready for review. ----- Review issues: > - If your application is a C or C++ application you must list a > BuildRequires against gcc, gcc-c++ or clang. Not a C or C++ application so not applicable. > Regarding %check: Upstream only has tests to help with speed testing, and those require connectivity. No tests applicable to building and no tests usable offline. > rustscan.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/rustscan Looking for feedback on this issue and if it's a blocker. > rustscan.x86_64: W: incoherent-version-in-changelog 2.2.3-1 ['2.3.0-1.fc41', '2.3.0-1'] Fixed in linked spec file. ----- Additional note: crates[.]io crate has only recently come back into use. There are issues with that crate, however, so we're still using src for now. This package will most likely switch to crates[.]io in the future once it (and if) it becomes a stable source for the project. Two quick comments: > > rustscan.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/rustscan > Looking for feedback on this issue and if it's a blocker. This usually points towards a bug / issue in the program. > crates[.]io crate has only recently come back into use. There are issues with that crate, however, so we're still using src for now. This package will most likely switch to crates[.]io in the future once it (and if) it becomes a stable source for the project. If you package this as "rustscan", then you don't need to switch to the crate published on crates.io at all. |