Bug 2295191
| Summary: | Review Request: fedora-repoquery - Fedora repoquery tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://hackage.haskell.org/package/fedora-repoquery | ||
| Whiteboard: | |||
| Fixed In Version: | fedora-repoquery-0.7-1.fc41 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-30 01:32:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jens Petersen
2024-07-02 15:39:48 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=119899190 There is a copr repo: https://copr.fedorainfracloud.org/coprs/petersen/fedora-repoquery/ Copr build: https://copr.fedorainfracloud.org/coprs/build/7698760 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295191-fedora-repoquery/fedora-rawhide-x86_64/07698760-fedora-repoquery/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://petersen.fedorapeople.org/reviews/fedora-repoquery/fedora-repoquery.spec SRPM URL: https://petersen.fedorapeople.org/reviews/fedora-repoquery/fedora-repoquery-0.6-1.fc41.src.rpm - https://hackage.haskell.org/package/fedora-repoquery-0.6/changelog Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=120589373 > %bcond_with tests I don't think we should use the old form, but that's something to fix in cabal-rpm. Doesn't make sense to change this manually here. > %changelog Can we please use %autorelease+%autochangelog for new packages? Anyway, the package looks good. I asked in the fedora-devel thread about renaming the tool though. Thanks for looking, Zbigniew (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > > %bcond_with tests > > I don't think we should use the old form, but that's something to fix in > cabal-rpm. > Doesn't make sense to change this manually here. Good point, I will change that in the next cabal-rpm release (after 2.2.1). > > > %changelog > > Can we please use %autorelease+%autochangelog for new packages? Sure thing - I sometimes find rpmautospec awkward during the review phase, but I can do that now. I have been converting most Haskell packages to autospec. > Anyway, the package looks good. I asked in the fedora-devel thread about > renaming the tool though. Thanks! Spec URL: https://petersen.fedorapeople.org/reviews/fedora-repoquery/fedora-repoquery.spec SRPM URL: https://petersen.fedorapeople.org/reviews/fedora-repoquery/fedora-repoquery-0.7-1.fc41.src.rpm - dropped fdrq and switched to using using libcurl Packaging is generated by cabal-rpm, so there isn't too much to review. + package name is OK + license is acceptable for Fedora (GPL-3.0-or-later) + license is specified correctly + builds and installs OK + BR/P/R look OK Package is APPROVED. Thank you for the review, Zbigniew! The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-repoquery FEDORA-2024-78a613ec1d (fedora-repoquery-0.7-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-78a613ec1d FEDORA-2024-8226596873 (fedora-repoquery-0.7-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8226596873 FEDORA-EPEL-2024-c4e0ec3fb7 (fedora-repoquery-0.7-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-c4e0ec3fb7 FEDORA-EPEL-2024-c4e0ec3fb7 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-c4e0ec3fb7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-8226596873 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8226596873 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8226596873 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-78a613ec1d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-78a613ec1d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-78a613ec1d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-78a613ec1d (fedora-repoquery-0.7-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-8226596873 (fedora-repoquery-0.7-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-c4e0ec3fb7 (fedora-repoquery-0.7-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |