Bug 2295191 - Review Request: fedora-repoquery - Fedora repoquery tool
Summary: Review Request: fedora-repoquery - Fedora repoquery tool
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL: https://hackage.haskell.org/package/f...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-07-02 15:39 UTC by Jens Petersen
Modified: 2024-07-30 02:01 UTC (History)
2 users (show)

Fixed In Version: fedora-repoquery-0.7-1.fc41
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-07-30 01:32:20 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Jens Petersen 2024-07-02 15:39:48 UTC
Spec URL: https://petersen.fedorapeople.org/reviews/fedora-repoquery/fedora-repoquery.spec
SRPM URL: https://petersen.fedorapeople.org/reviews/fedora-repoquery/fedora-repoquery-0.5-1.fc41.src.rpm

Description:
A CLI tool for repoquerying Fedora packages: by default it displays their
version and repo location with compose timestamp.

Comment 2 Fedora Review Service 2024-07-02 15:49:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7698760
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295191-fedora-repoquery/fedora-rawhide-x86_64/07698760-fedora-repoquery/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Zbigniew Jędrzejewski-Szmek 2024-07-18 11:01:36 UTC
> %bcond_with tests

I don't think we should use the old form, but that's something to fix in cabal-rpm.
Doesn't make sense to change this manually here.

> %changelog

Can we please use %autorelease+%autochangelog for new packages?

Anyway, the package looks good. I asked in the fedora-devel thread about
renaming the tool though.

Comment 5 Jens Petersen 2024-07-18 11:17:33 UTC
Thanks for looking, Zbigniew

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> > %bcond_with tests
> 
> I don't think we should use the old form, but that's something to fix in
> cabal-rpm.
> Doesn't make sense to change this manually here.

Good point, I will change that in the next cabal-rpm release (after 2.2.1).

> 
> > %changelog
> 
> Can we please use %autorelease+%autochangelog for new packages?

Sure thing - I sometimes find rpmautospec awkward during the review phase,
but I can do that now.  I have been converting most Haskell packages to autospec.

> Anyway, the package looks good. I asked in the fedora-devel thread about
> renaming the tool though.

Thanks!

Comment 7 Zbigniew Jędrzejewski-Szmek 2024-07-19 11:05:13 UTC
Packaging is generated by cabal-rpm, so there isn't too much to review.

+ package name is OK
+ license is acceptable for Fedora (GPL-3.0-or-later)
+ license is specified correctly
+ builds and installs OK
+ BR/P/R look OK

Package is APPROVED.

Comment 8 Jens Petersen 2024-07-21 07:16:00 UTC
Thank you for the review, Zbigniew!

Comment 9 Fedora Admin user for bugzilla script actions 2024-07-21 07:16:11 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-repoquery

Comment 10 Fedora Update System 2024-07-21 08:15:55 UTC
FEDORA-2024-78a613ec1d (fedora-repoquery-0.7-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-78a613ec1d

Comment 11 Fedora Update System 2024-07-21 08:40:37 UTC
FEDORA-2024-8226596873 (fedora-repoquery-0.7-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8226596873

Comment 13 Fedora Update System 2024-07-21 11:36:41 UTC
FEDORA-EPEL-2024-c4e0ec3fb7 (fedora-repoquery-0.7-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-c4e0ec3fb7

Comment 14 Fedora Update System 2024-07-22 01:58:38 UTC
FEDORA-EPEL-2024-c4e0ec3fb7 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-c4e0ec3fb7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-07-22 02:11:13 UTC
FEDORA-2024-8226596873 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8226596873 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8226596873

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-07-22 02:21:23 UTC
FEDORA-2024-78a613ec1d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-78a613ec1d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-78a613ec1d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-07-30 01:32:20 UTC
FEDORA-2024-78a613ec1d (fedora-repoquery-0.7-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-07-30 01:44:04 UTC
FEDORA-2024-8226596873 (fedora-repoquery-0.7-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-07-30 02:01:08 UTC
FEDORA-EPEL-2024-c4e0ec3fb7 (fedora-repoquery-0.7-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.