Bug 2295815

Summary: Review Request: rust-pcap-file - A crate to parse, read and write Pcap and PcapNg
Product: [Fedora] Fedora Reporter: Paolo Valerio <pvalerio>
Component: Package ReviewAssignee: Fernando F. Mancera <ferferna>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: amorenoz, atenart, decathorpe, ferferna, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: ferferna: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/pcap-file
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-12-18 17:58:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2295805, 2295811    
Bug Blocks: 177841, 2295792    

Description Paolo Valerio 2024-07-04 15:14:38 UTC
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-pcap-file.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/07671887-rust-pcap-file/rust-pcap-file-2.0.0-1.fc41.src.rpm
Description: Provides parsers, readers and writers for Pcap and PcapNg files.
Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671887/

Fedora Account System Username: atenart, pvaler, amorenoz

I’m starting this review request on behalf of Antoine, Adrián and me. We want to maintain it as a group. It’s our first package and we’ll need a sponsor.

Comment 1 Fedora Review Service 2024-07-04 15:56:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7708314
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295815-rust-pcap-file/fedora-rawhide-x86_64/07708314-rust-pcap-file/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Paul Pfeister 2024-07-06 22:20:05 UTC
Blocked FE-NEEDSPONSOR as you mention still requiring a sponsor

Comment 3 Fernando F. Mancera 2024-12-02 09:22:52 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-12-02 09:32:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8333079
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295815-rust-pcap-file/fedora-rawhide-x86_64/08333079-rust-pcap-file/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2024-12-03 14:49:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8337894
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295815-rust-pcap-file/fedora-rawhide-x86_64/08337894-rust-pcap-file/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fabio Valentini 2024-12-08 17:20:37 UTC
Same question here - you changed the bug assignee to yourself, but didn't change the bug status?
If you need help, I'd be happy to review the package.

Comment 8 Fernando F. Mancera 2024-12-18 12:02:51 UTC
Specfile was generated using rust2rpm.

Check list for rust package:

[X] package contains only permissible content
[X] package builds and installs without errors on rawhide
[X] test suite is run and all unit tests pass
[X] latest version of the crate is packaged
[X] license matches upstream specification and is acceptable for Fedora
[X] license file is included with %license in %files
[X] package complies with Rust Packaging Guidelines

Package APPROVED!

Please note that the package doesn't build in F41 or F40 but that is fine.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment 9 Fernando F. Mancera 2024-12-18 12:03:27 UTC
Hi Fabio, thank you! I just did the review, I just got an unexpected time-off in the middle :)

Comment 10 Fedora Admin user for bugzilla script actions 2024-12-18 16:40:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pcap-file

Comment 11 Fedora Update System 2024-12-18 17:06:55 UTC
FEDORA-2024-746ffc7d7c (rust-pcap-file-2.0.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-746ffc7d7c

Comment 12 Fedora Update System 2024-12-18 17:58:49 UTC
FEDORA-2024-746ffc7d7c (rust-pcap-file-2.0.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.