Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/retis.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/07683454-retis/retis-1.5.0-0.fc41.src.rpm Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7683454/ Description: Tracing packets in the Linux networking stack, using eBPF and interfacing with control and data paths such as OpenVSwitch. Fedora Account System Usernames: atenart, pvaler, amorenoz I’m starting this review request on behalf of Paolo, Adrián and me. We’d like to maintain it as a group. It’s our first package and we’ll need a sponsor. We’re also the upstream maintainers of Retis (https://github.com/retis-org/retis). In order to build Retis, extra Rust crates need to be packaged too: - rust-btf-rs - rust-byteorder_slice - rust-derive-into-owned - rust-pcap-file - rust-pnet_macros - rust-pnet_macros_support - rust-pnet_packet The following packages need to be updated: - rust-elf: this was already discussed (https://src.fedoraproject.org/rpms/rust-elf/pull-request/1) and the plan is to also upgrade rust-rbspy-testdata and rust-rbspy. All spec files can be found here, https://github.com/retis-org/copr-playground/tree/main. Those packages were built here, https://copr.fedorainfracloud.org/coprs/g/retis/playground/builds/. We’re opening one dedicated bz per package but we’re listing those here so you can have the full picture. Notes: - The Retis spec file listed here is using a commit hash instead of a released version (but the final logic is there under %if 0). We’ll release an official Retis version for the initial package of course, but since there are multiple dependencies and potential changes needed, not releasing right away gives us more flexibility. - We reached out to the Fedora Rust ml with our plan earlier this year, https://lists.fedoraproject.org/archives/list/rust@lists.fedoraproject.org/thread/5ZQB6UAN7H4UHDQMI5QZVSDSIWM2OE7I/. - We're already distributing Retis as an RPM in COPR here, https://copr.fedorainfracloud.org/coprs/g/retis/retis/ (spec file is not the same as the one here and has lots of shortcuts).
Copr build: https://copr.fedorainfracloud.org/coprs/build/7707867 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295792-retis/fedora-rawhide-x86_64/07707867-retis/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Blocked FE-NEEDSPONSOR as you mention still requiring a sponsor Ref: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_contributor (bullet #3)
All prerequisites are now done, which means we can now tackle the Retis inclusion itself. Finally! The spec file was updated and 4 out of tree patches were added. A description for each of them is given in the spec file. Those were manually generated as we don't use rust2rpm here. Spec URL: https://github.com/retis-org/copr-playground/blob/0d8659d2dd075155611c7ab9b893fb82e0759eb0/retis.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/08801956-retis/retis-1.5.2-0.fc43.src.rpm Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/8801956/ Thanks!
Copr build: https://copr.fedorainfracloud.org/coprs/build/8802030 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295792-retis/fedora-rawhide-x86_64/08802030-retis/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv2'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixed the SPDX license in the spec file. Spec URL: https://github.com/retis-org/copr-playground/blob/2f4433edbab65a95543b59f5e3a21150621989dc/retis.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/08802186-retis/retis-1.5.2-0.fc43.src.rpm Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/8802186/
Created attachment 2081264 [details] The .spec file difference from Copr build 8802030 to 8802233
Copr build: https://copr.fedorainfracloud.org/coprs/build/8802233 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295792-retis/fedora-rawhide-x86_64/08802233-retis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hey there! I have been reviewing this package. These are my findings: [X] Builds in Fedora rawhide and Fedora 42 [X] License matches upstream specification and is acceptable for Fedora [X] License is installed properly [X] Test are passing [X] Latest version is packaged Notes: There are some rpmlint warnings but I think the most relevant one is: - retis.x86_64: W: no-manual-page-for-binary retis Please, consider adding a manual page in the future. Result: APPROVED!
The Pagure repository was created at https://src.fedoraproject.org/rpms/retis
FEDORA-2025-258f476ae7 (retis-1.5.2-0.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-258f476ae7
FEDORA-2025-258f476ae7 (retis-1.5.2-0.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.