Bug 2296142

Summary: Review Request: rust-minicbor - Small CBOR codec suitable for no_std environments
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/minicbor
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-16 14:05:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2296141    
Bug Blocks:    

Description Davide Cavalca 2024-07-06 23:15:50 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-minicbor/rust-minicbor.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-minicbor/rust-minicbor-0.24.2-1.fc41.src.rpm

Description:
A small CBOR codec suitable for no_std environments.

Fedora Account System Username: dcavalca

Comment 1 Fedora Review Service 2024-07-08 00:39:39 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7716061
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296142-rust-minicbor/fedora-rawhide-x86_64/07716061-rust-minicbor/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-09-12 16:32:48 UTC
The minicbor executable doesn't look very useful. Are you sure you want to package it?

Comment 3 Fabio Valentini 2024-09-12 16:33:11 UTC
There's also a few new releases (0.24.4 in the 0.24.x branch, and a new 0.25.x branch), please update if possible.

Comment 5 Davide Cavalca 2024-09-15 20:40:22 UTC
$ cat rust2rpm.toml 
[package]
cargo-install-bin = false

Comment 6 Fedora Review Service 2024-09-16 08:48:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8023388
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296142-rust-minicbor/fedora-rawhide-x86_64/08023388-rust-minicbor/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fabio Valentini 2024-09-16 12:06:49 UTC
Looks good to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fedora Admin user for bugzilla script actions 2024-09-16 13:52:17 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-minicbor

Comment 9 Fedora Update System 2024-09-16 14:02:22 UTC
FEDORA-2024-6b53fdf614 (rust-minicbor-0.25.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6b53fdf614

Comment 10 Fedora Update System 2024-09-16 14:05:22 UTC
FEDORA-2024-6b53fdf614 (rust-minicbor-0.25.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-09-16 14:15:53 UTC
FEDORA-2024-2682f2c6f4 (rust-minicbor-0.25.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2682f2c6f4

Comment 12 Fedora Update System 2024-09-16 14:40:08 UTC
FEDORA-2024-17f73e7080 (rust-minicbor-0.25.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-17f73e7080

Comment 13 Fedora Update System 2024-09-17 03:07:56 UTC
FEDORA-2024-2682f2c6f4 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2682f2c6f4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2682f2c6f4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-09-18 01:42:56 UTC
FEDORA-2024-17f73e7080 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-17f73e7080 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-17f73e7080

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-09-25 01:29:22 UTC
FEDORA-2024-2682f2c6f4 (rust-minicbor-0.25.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-09-26 02:44:21 UTC
FEDORA-2024-17f73e7080 (rust-minicbor-0.25.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.