Bug 2296141 - Review Request: rust-minicbor-derive - Derive minicbor Decode and Encode traits
Summary: Review Request: rust-minicbor-derive - Derive minicbor Decode and Encode traits
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/minicbor-derive
Whiteboard:
Depends On:
Blocks: 2296142
TreeView+ depends on / blocked
 
Reported: 2024-07-06 23:15 UTC by Davide Cavalca
Modified: 2024-07-23 14:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-14 15:57:31 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-07-06 23:15:14 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-minicbor-derive/rust-minicbor-derive.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-minicbor-derive/rust-minicbor-derive-0.15.0-1.fc41.src.rpm

Description:
Derive minicbor `Decode` and `Encode` traits.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-07-06 23:15:16 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=120102010

Comment 2 Davide Cavalca 2024-07-06 23:15:57 UTC
$ cat rust2rpm.toml 
[tests]
run = ["none"]
comments = ["Tests require minicbor, which isn't actually included"]

Comment 3 Fedora Review Service 2024-07-08 00:52:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7716060
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296141-rust-minicbor-derive/fedora-rawhide-x86_64/07716060-rust-minicbor-derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-07-13 21:04:10 UTC
> # * Tests require minicbor, which isn't actually included

This means minicbor is a dev-dependency that was only specified as a "path".
This results in tests only being able to be compiled and run "in-tree".

Also, BlueOak-1.0.0 is the strangest license I've seen yet ... but it's on the list of allowed / good licenses for Fedora, so I guess it's OK.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (disabled with justification)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2024-07-14 15:46:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-minicbor-derive

Comment 6 Fedora Update System 2024-07-14 15:54:23 UTC
FEDORA-2024-58e6c6ea34 (rust-minicbor-derive-0.15.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-58e6c6ea34

Comment 7 Fedora Update System 2024-07-14 15:57:31 UTC
FEDORA-2024-58e6c6ea34 (rust-minicbor-derive-0.15.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-07-14 16:09:09 UTC
FEDORA-2024-88af691792 (rust-minicbor-derive-0.15.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-88af691792

Comment 9 Fedora Update System 2024-07-14 16:19:27 UTC
FEDORA-2024-f481084df0 (rust-minicbor-derive-0.15.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f481084df0

Comment 10 Fedora Update System 2024-07-15 02:07:08 UTC
FEDORA-2024-f481084df0 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f481084df0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f481084df0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-07-15 03:05:30 UTC
FEDORA-2024-88af691792 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-88af691792 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-88af691792

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-07-23 01:31:19 UTC
FEDORA-2024-f481084df0 (rust-minicbor-derive-0.15.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-07-23 14:05:12 UTC
FEDORA-2024-88af691792 (rust-minicbor-derive-0.15.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.