Bug 2296274

Summary: Review Request: qhotkey - A global shortcut library for Desktop Qt-Applications
Product: [Fedora] Fedora Reporter: MartinKG <mgansser>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dominik, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/Skycoder42/QHotkey
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-22 06:50:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description MartinKG 2024-07-08 11:53:37 UTC
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qhotkey.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qhotkey-1.5.0-1.fc40.src.rpm

Description: QHotkey is a library to handle global shortcuts (hotkeys) in Qt applications, on both Windows and Linux (X11).

Fedora Account System Username: martinkg

%changelog
* Sat Jul 06 2024 Martin Gansser <martinkg> - 1.5.0-1
- Initial package

$ rpmlint -v qhotkey.spec /home/martin/rpmbuild/SRPMS/qhotkey-1.5.0-1.fc40.src.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-devel-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-devel-1.5.0-1.fc40.x86_64.rpm
154 blocks
42 blocks
212 blocks
42 blocks
111 blocks
============================================================================================ rpmlint session starts ============================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 6

qhotkey-qt5-devel.x86_64: W: only-non-binary-in-usr-lib
qhotkey-qt6-devel.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

qhotkey-qt5.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/libqhotkey.so
qhotkey-qt6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt6/libqhotkey.so
A file that is needed only e.g. when developing or building software is
included in a non-devel package. These files should go in devel packages.

====================================================== 5 packages and 1 specfiles checked; 0 errors, 4 warnings, 19 filtered, 0 badness; has taken 0.9 s ======================================================

Comment 1 MartinKG 2024-07-09 08:06:40 UTC
new rpmlint information

$ rpmlint -v qhotkey.spec /home/martin/rpmbuild/SRPMS/qhotkey-1.5.0-1.fc40.src.rpm  /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-devel-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-devel-1.5.0-1.fc40.x86_64.rpm
154 blocks
43 blocks
204 blocks
43 blocks
112 blocks
============================================================================================ rpmlint session starts =================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 6

qhotkey-qt5-devel.x86_64: W: only-non-binary-in-usr-lib
qhotkey-qt6-devel.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

====================================================== 5 packages and 1 specfiles checked; 0 errors, 2 warnings, 21 filtered, 0 badness; has taken 0.8 s ===============

Comment 2 Fedora Review Service 2024-07-09 13:30:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7719899
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296274-qhotkey/fedora-rawhide-x86_64/07719899-qhotkey/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 MartinKG 2024-08-08 09:14:45 UTC
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qhotkey.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qhotkey-1.5.0-2.fc40.src.rpm

%changelog
* Thu Aug 08 2024 Martin Gansser <martinkg> - 1.5.0-2
- Add %%{name}-fix-crash-on-wayland-qt6.patch