Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qhotkey.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qhotkey-1.5.0-1.fc40.src.rpm Description: QHotkey is a library to handle global shortcuts (hotkeys) in Qt applications, on both Windows and Linux (X11). Fedora Account System Username: martinkg %changelog * Sat Jul 06 2024 Martin Gansser <martinkg> - 1.5.0-1 - Initial package $ rpmlint -v qhotkey.spec /home/martin/rpmbuild/SRPMS/qhotkey-1.5.0-1.fc40.src.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-devel-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-devel-1.5.0-1.fc40.x86_64.rpm 154 blocks 42 blocks 212 blocks 42 blocks 111 blocks ============================================================================================ rpmlint session starts ============================================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 qhotkey-qt5-devel.x86_64: W: only-non-binary-in-usr-lib qhotkey-qt6-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. qhotkey-qt5.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/libqhotkey.so qhotkey-qt6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt6/libqhotkey.so A file that is needed only e.g. when developing or building software is included in a non-devel package. These files should go in devel packages. ====================================================== 5 packages and 1 specfiles checked; 0 errors, 4 warnings, 19 filtered, 0 badness; has taken 0.9 s ======================================================
new rpmlint information $ rpmlint -v qhotkey.spec /home/martin/rpmbuild/SRPMS/qhotkey-1.5.0-1.fc40.src.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt5-devel-1.5.0-1.fc40.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qhotkey-qt6-devel-1.5.0-1.fc40.x86_64.rpm 154 blocks 43 blocks 204 blocks 43 blocks 112 blocks ============================================================================================ rpmlint session starts ================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 qhotkey-qt5-devel.x86_64: W: only-non-binary-in-usr-lib qhotkey-qt6-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. ====================================================== 5 packages and 1 specfiles checked; 0 errors, 2 warnings, 21 filtered, 0 badness; has taken 0.8 s ===============
Copr build: https://copr.fedorainfracloud.org/coprs/build/7719899 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296274-qhotkey/fedora-rawhide-x86_64/07719899-qhotkey/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qhotkey.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qhotkey-1.5.0-2.fc40.src.rpm %changelog * Thu Aug 08 2024 Martin Gansser <martinkg> - 1.5.0-2 - Add %%{name}-fix-crash-on-wayland-qt6.patch