Bug 2296791

Summary:	Review Request: ghc-config-schema - Schema definitions for the config-value package
Product:	[Fedora] Fedora	Reporter:	Frank Dedden <frank>
Component:	Package Review	Assignee:	Jens Petersen <petersen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	haskell-devel, package-review
Target Milestone:	---	Flags:	petersen: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://hackage.haskell.org/package/config-schema
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-10-21 09:45:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Frank Dedden 2024-07-09 17:51:02 UTC

Spec URL: https://fdedden.fedorapeople.org/ghc-config-schema.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-config-schema-1.3.0.0-1.fc41.src.rpm

Description:
This package makes it possible to define schemas for use when loading
configuration files using the config-value format. These schemas can be used to
process a configuration file into a Haskell value or to automatically generate
documentation for the file format.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-07-09 17:51:04 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=120244965

Comment 2 Fedora Review Service 2024-07-09 19:24:16 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7720583
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296791-ghc-config-schema/fedora-rawhide-x86_64/07720583-ghc-config-schema/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jens Petersen 2024-08-15 16:40:53 UTC

Looks fine to me

- No serious differences with cabal-rpm spec
  - I did notice in a few of the reviews (including this one)
    where the .cabal file gets revised, you don't use dos2unix
    to convert the revised .cabal to unix line endings.
    I don't think it is too serious, but iirc it is required,
    so better to do so. Could this be some kind of cabal-rpm bug?
    It works for me anyway: I wondered why you aren't getting that:
    I put the cabal-rpm diff output below for reference.
- License is ISC and package complies with Packaging Guidelines
- builds and installs fine

Package is APPROVED


$ cabal-rpm diff
ghc-config-schema
--- ghc-config-schema.spec	2024-07-09 08:00:00.000000000 +0800
+++ ghc-config-schema.spec.cblrpm	2024-08-16 00:26:52.768187444 +0800
:
 Source1:        https://hackage.haskell.org/package/%{pkgver}/%{pkg_name}.cabal#/%{pkgver}.cabal
 # End cabal-rpm sources
 
 # Begin cabal-rpm deps:
+BuildRequires:  dos2unix
 BuildRequires:  ghc-Cabal-devel
 BuildRequires:  ghc-rpm-macros
 BuildRequires:  ghc-base-devel
@@ -89,7 +90,7 @@
 %prep
 # Begin cabal-rpm setup:
 %setup -q -n %{pkgver}
-cp -bp %{SOURCE1} %{pkg_name}.cabal
+dos2unix -k -n %{SOURCE1} %{pkg_name}.cabal
 # End cabal-rpm setup

Comment 4 Fedora Admin user for bugzilla script actions 2024-08-22 18:29:52 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-config-schema