Spec URL: https://fdedden.fedorapeople.org/ghc-config-schema.spec SRPM URL: https://fdedden.fedorapeople.org/ghc-config-schema-1.3.0.0-1.fc41.src.rpm Description: This package makes it possible to define schemas for use when loading configuration files using the config-value format. These schemas can be used to process a configuration file into a Haskell value or to automatically generate documentation for the file format. Fedora Account System Username: fdedden
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=120244965
Copr build: https://copr.fedorainfracloud.org/coprs/build/7720583 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296791-ghc-config-schema/fedora-rawhide-x86_64/07720583-ghc-config-schema/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks fine to me - No serious differences with cabal-rpm spec - I did notice in a few of the reviews (including this one) where the .cabal file gets revised, you don't use dos2unix to convert the revised .cabal to unix line endings. I don't think it is too serious, but iirc it is required, so better to do so. Could this be some kind of cabal-rpm bug? It works for me anyway: I wondered why you aren't getting that: I put the cabal-rpm diff output below for reference. - License is ISC and package complies with Packaging Guidelines - builds and installs fine Package is APPROVED $ cabal-rpm diff ghc-config-schema --- ghc-config-schema.spec 2024-07-09 08:00:00.000000000 +0800 +++ ghc-config-schema.spec.cblrpm 2024-08-16 00:26:52.768187444 +0800 : Source1: https://hackage.haskell.org/package/%{pkgver}/%{pkg_name}.cabal#/%{pkgver}.cabal # End cabal-rpm sources # Begin cabal-rpm deps: +BuildRequires: dos2unix BuildRequires: ghc-Cabal-devel BuildRequires: ghc-rpm-macros BuildRequires: ghc-base-devel @@ -89,7 +90,7 @@ %prep # Begin cabal-rpm setup: %setup -q -n %{pkgver} -cp -bp %{SOURCE1} %{pkg_name}.cabal +dos2unix -k -n %{SOURCE1} %{pkg_name}.cabal # End cabal-rpm setup
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-config-schema