Bug 2301608

Summary:	Review Request: ghc-crypton-connection - Simple and easy network connections API
Product:	[Fedora] Fedora	Reporter:	Jens Petersen <petersen>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://hackage.haskell.org/package/crypton-connection
Whiteboard:
Fixed In Version:	ghc-crypton-connection-0.3.2-2.fc41	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-08-13 16:36:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2300441, 2300470
Bug Blocks:

Description Jens Petersen 2024-07-30 12:13:45 UTC

Spec URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection.spec
SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection-0.3.2-1.fc41.src.rpm

Description:
Simple network library for all your connection need.

Features: Really simple to use, SSL/TLS, SOCKS.

This library provides a very simple api to create sockets to a destination with
the choice of SSL/TLS, and SOCKS.

Comment 1 Jens Petersen 2024-07-30 12:18:29 UTC

This is rename of ghc-connections to the new crypton upstream package.

Comment 2 Jens Petersen 2024-08-01 14:54:16 UTC

Spec URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection.spec
SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection-0.3.2-2.fc41.src.rpm

- obsoletes ghc-connection

Comment 3 Fedora Review Service 2024-08-01 14:57:33 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7816306
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2301608-ghc-crypton-connection/fedora-rawhide-x86_64/07816306-ghc-crypton-connection/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Zbigniew Jędrzejewski-Szmek 2024-08-04 10:07:43 UTC

+ package follows Haskell packaging guidelines and the standard template
+ package name is OK (Lib)
+ license is acceptable for Fedora (BSD*)
+ license is specified correctly in SPDX format
+ package should build and install correctly when the deps are available

Package is APPROVED.

Grammar: "network connection API", "all your connection needs"

Comment 5 Fedora Admin user for bugzilla script actions 2024-08-05 08:46:23 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-crypton-connection

Comment 6 Jens Petersen 2024-08-05 08:46:32 UTC

Thank you for the review, Zbigniew

Comment 7 Jens Petersen 2024-08-05 09:17:09 UTC

> Grammar: "network connection API", "all your connection needs"

Thanks, good catch - I opened an PR upstream:
https://github.com/kazu-yamamoto/crypton-connection/pull/5

(though the wordings were inherited from the old connection package:)