Spec URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection-0.3.2-1.fc41.src.rpm Description: Simple network library for all your connection need. Features: Really simple to use, SSL/TLS, SOCKS. This library provides a very simple api to create sockets to a destination with the choice of SSL/TLS, and SOCKS.
This is rename of ghc-connections to the new crypton upstream package.
Spec URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-crypton-connection/ghc-crypton-connection-0.3.2-2.fc41.src.rpm - obsoletes ghc-connection
Copr build: https://copr.fedorainfracloud.org/coprs/build/7816306 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2301608-ghc-crypton-connection/fedora-rawhide-x86_64/07816306-ghc-crypton-connection/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
+ package follows Haskell packaging guidelines and the standard template + package name is OK (Lib) + license is acceptable for Fedora (BSD*) + license is specified correctly in SPDX format + package should build and install correctly when the deps are available Package is APPROVED. Grammar: "network connection API", "all your connection needs"
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-crypton-connection
Thank you for the review, Zbigniew
> Grammar: "network connection API", "all your connection needs" Thanks, good catch - I opened an PR upstream: https://github.com/kazu-yamamoto/crypton-connection/pull/5 (though the wordings were inherited from the old connection package:)