Bug 2302682

Summary: Review Request: rust-hyper-rustls0.25 - Rustls+hyper integration for pure rust HTTPS
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-04 17:33:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2302681    
Bug Blocks: 2302683    

Description Davide Cavalca 2024-08-04 01:41:23 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-hyper-rustls0.25/rust-hyper-rustls0.25.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-hyper-rustls0.25/rust-hyper-rustls0.25-0.25.0-1.fc41.src.rpm

Description:
Rustls+hyper integration for pure rust HTTPS.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-08-04 01:41:38 UTC
$ cat rust2rpm.toml 
[tests]
skip = [
    "client",
    "custom_ca_store",
    "server",
]
skip-exact = true
comments = ["files needed by integration tests are not included in published crates"]

Comment 2 Michel Lind 2024-08-04 02:06:17 UTC
Generated with rust2rpm, rust2rpm.toml identical to https://src.fedoraproject.org/rpms/rust-hyper-rustls/blob/9e6e77cb25cbbf91334c513a15e74fe94ce09e1b/f/rust2rpm.toml (for 0.26)

APPROVED

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fabio Valentini 2024-08-04 15:21:17 UTC
In general, I would like to avoid having compat packages for cryptography-related crates unless absolutely necessary.
- especially if we already have a newer version in Fedora and you're adding a compat package for an *old* version (vs. creating a compat package in order to be able to ship an update).

What do you need the old version for? If possible, please try to bump the dependency instead.

Comment 4 Davide Cavalca 2024-08-04 16:32:25 UTC
This is for redlib: https://bugzilla.redhat.com/show_bug.cgi?id=2302683

Unfortunately I can't just bump this, it's intertwined with hyper which has breaking API changes, so bumping both breaks the build badly.

Comment 5 Fabio Valentini 2024-08-04 16:40:57 UTC
Hm. We already have a compat package for v0.24 for a similar reason. Can you try downgrading from v0.25 to v0.24 instead of bumping to v0.26?

Comment 6 Davide Cavalca 2024-08-04 16:47:32 UTC
Unfortunately redlib doesn't build with 0.24, looks like it's using an API that was introduced in 0.25 :(

Comment 7 Fedora Admin user for bugzilla script actions 2024-08-04 16:56:34 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hyper-rustls0.25

Comment 8 Fedora Update System 2024-08-04 17:30:45 UTC
FEDORA-2024-e79408b435 (rust-hyper-rustls0.25-0.25.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e79408b435

Comment 9 Fedora Update System 2024-08-04 17:33:03 UTC
FEDORA-2024-e79408b435 (rust-hyper-rustls0.25-0.25.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.