Bug 2302681 - Review Request: rust-tokio-rustls0.25 - Asynchronous TLS/SSL streams for Tokio using Rustls
Summary: Review Request: rust-tokio-rustls0.25 - Asynchronous TLS/SSL streams for Toki...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2302682
TreeView+ depends on / blocked
 
Reported: 2024-08-04 01:40 UTC by Davide Cavalca
Modified: 2024-08-04 17:12 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-04 17:12:03 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-08-04 01:40:35 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-tokio-rustls0.25/rust-tokio-rustls0.25.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-tokio-rustls0.25/rust-tokio-rustls0.25-0.25.0-1.fc41.src.rpm

Description:
Asynchronous TLS/SSL streams for Tokio using Rustls.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-08-04 01:40:56 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=121478772

$ cat rust2rpm.toml 
[tests]
skip = [
    "common::test_stream::stream_bad",
    "common::test_stream::stream_eof",
    "common::test_stream::stream_good",
    "common::test_stream::stream_buffered_handshake",
    "common::test_stream::stream_handshake",
    "common::test_stream::stream_handshake_regression_issues_77",
    "test_modern",
    "test_tls12",
    "test_lazy_config_acceptor",
    "pass",
]
skip-exact = true
comments = [
  "skip tests that require internet access",
  "skip tests relying on expired certificates",
]

Comment 2 Michel Lind 2024-08-04 02:03:56 UTC
Compat package, basically identical to https://src.fedoraproject.org/rpms/rust-tokio-rustls/tree/f0ed26cefd170c212612405aae34663d63d3d38c except more tests now needs to be skipped

APPROVED

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fabio Valentini 2024-08-04 15:21:39 UTC
In general, I would like to avoid having compat packages for cryptography-related crates unless absolutely necessary.
- especially if we already have a newer version in Fedora and you're adding a compat package for an *old* version (vs. creating a compat package in order to be able to ship an update).

What do you need the old version for? If possible, please try to bump the dependency instead.

Comment 4 Davide Cavalca 2024-08-04 16:33:10 UTC
See https://bugzilla.redhat.com/show_bug.cgi?id=2302682#c4, this is needed for hyper-rustls which is needed for redlib. There's an API break so bumping it is unfortunately not an option.

Comment 5 Fedora Admin user for bugzilla script actions 2024-08-04 16:54:03 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tokio-rustls0.25

Comment 6 Fedora Update System 2024-08-04 17:07:45 UTC
FEDORA-2024-3bca464ec1 (rust-tokio-rustls0.25-0.25.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3bca464ec1

Comment 7 Fedora Update System 2024-08-04 17:12:03 UTC
FEDORA-2024-3bca464ec1 (rust-tokio-rustls0.25-0.25.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.