Bug 2303600
| Summary: | Review Request: emilua - Lua execution engine | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Valter Nazianzeno <manipuladordedados> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | manipuladordedados, package-review, zbyszek |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://gitlab.com/emilua/emilua | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Valter Nazianzeno
2024-08-08 01:41:26 UTC
Please add a comment in the spec file that explains what the two sources are. rpmautospec (https://docs.pagure.org/fedora-infra.rpmautospec/) is generally recommended instead of the manual changelog/release handling. Looks nice in general. Maybe extend the %description a bit to explain how/why another lua engine is useful? > ExclusiveArch: i386 i686 x86_64 aarch64 Please add a comment explaining why other arches are not supported. In general, %{ix86} should be used instead of listing the i386 variants. But it's better to drop support for i386. It generally should not be added in new packages, see https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval. Thank you for the suggestions, the package has been updated. The package has been updated to a new version. https://copr.fedorainfracloud.org/coprs/manipuladordedados/emilua/ Spec URL: https://download.copr.fedorainfracloud.org/results/manipuladordedados/emilua/fedora-rawhide-x86_64/08028920-emilua/emilua.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/manipuladordedados/emilua/fedora-rawhide-x86_64/08028920-emilua/emilua-0.10.0-1.fc42.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/8028936 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2303600-emilua/fedora-rawhide-x86_64/08028936-emilua/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |