Bug 2303600 - Review Request: emilua - Lua execution engine
Summary: Review Request: emilua - Lua execution engine
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://gitlab.com/emilua/emilua
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-08-08 01:41 UTC by Valter Nazianzeno
Modified: 2024-09-17 21:01 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Valter Nazianzeno 2024-08-08 01:41:26 UTC
This is my first package and I am seeking a sponsor.

Spec URL: https://download.copr.fedorainfracloud.org/results/manipuladordedados/emilua/fedora-rawhide-x86_64/07894215-emilua/emilua.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/manipuladordedados/emilua/fedora-rawhide-x86_64/07894215-emilua/emilua-0.9.1-1.fc41.src.rpm

Description: emilua is a cross-platform execution engine for LuaJIT with support for async IO and flexible threading layout.
Fedora Account System Username: manipuladordedados

This package is also hosted in COPR and was built in Koji on F40 and Rawhide.
https://copr.fedorainfracloud.org/coprs/manipuladordedados/emilua/

Comment 1 Zbigniew Jędrzejewski-Szmek 2024-08-08 20:42:41 UTC
Please add a comment in the spec file that explains what the two sources are.

rpmautospec (https://docs.pagure.org/fedora-infra.rpmautospec/) is generally
recommended instead of the manual changelog/release handling.

Looks nice in general. Maybe extend the %description a bit to explain
how/why another lua engine is useful?

Comment 2 Zbigniew Jędrzejewski-Szmek 2024-08-08 20:46:39 UTC
> ExclusiveArch:  i386 i686 x86_64 aarch64

Please add a comment explaining why other arches are not supported.
In general, %{ix86} should be used instead of listing the i386 variants.
But it's better to drop support for i386. It generally should not be
added in new packages, see https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval.

Comment 3 Valter Nazianzeno 2024-08-08 22:19:26 UTC
Thank you for the suggestions, the package has been updated.

Comment 5 Fedora Review Service 2024-09-17 21:01:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8028936
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2303600-emilua/fedora-rawhide-x86_64/08028936-emilua/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.