Bug 2307083

Summary: Review Request: rust-tabwriter - Elastic tabstops
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/tabwriter
Whiteboard: Trivial
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-23 05:58:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2307325    

Description Ben Beasley 2024-08-21 21:00:23 UTC
Spec URL: https://music.fedorapeople.org/rust-tabwriter.spec
SRPM URL: https://music.fedorapeople.org/rust-tabwriter-1.4.0-1.fc40.src.rpm

Description:

Elastic tabstops.

Fedora Account System Username: music

This is a request for unretirement, https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming.

This is a test dependency for https://crates.io/crates/jiff, which I need to package in order to update https://src.fedoraproject.org/rpms/uv to 0.3.0.

Comment 1 Fedora Review Service 2024-08-21 21:14:07 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7932384
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307083-rust-tabwriter/fedora-rawhide-x86_64/07932384-rust-tabwriter/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-tabwriter
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2024-08-22 15:55:43 UTC
This package is the unmodified output of rust2rpm with no configuration file.

Comment 3 Michel Lind 2024-08-22 18:35:54 UTC
note: please make sure to preserve the old changelog by reverting the commit then doing rpmautospec convert

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Unlicense OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Ben Beasley 2024-08-22 19:09:32 UTC
Thank you for the review!

Unretirement requested: https://pagure.io/releng/issue/12281

Release monitoring was already mostly correctly configured (https://release-monitoring.org/project/16863/); I added the version filter "alpha;beta;rc;pre" and changed the version scheme to "Semantic".

Comment 5 Fedora Update System 2024-08-23 05:55:36 UTC
FEDORA-2024-e66ceee224 (rust-tabwriter-1.4.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e66ceee224

Comment 6 Fedora Update System 2024-08-23 05:58:44 UTC
FEDORA-2024-e66ceee224 (rust-tabwriter-1.4.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-08-23 06:05:32 UTC
FEDORA-2024-7d8ee38ef1 (rust-tabwriter-1.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7d8ee38ef1

Comment 8 Fedora Update System 2024-08-23 06:07:48 UTC
FEDORA-2024-7d8ee38ef1 (rust-tabwriter-1.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-08-23 12:23:06 UTC
FEDORA-2024-7a1b1d1bc6 (rust-tabwriter-1.4.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a1b1d1bc6

Comment 10 Fedora Update System 2024-08-23 12:40:43 UTC
FEDORA-2024-0407706c15 (rust-tabwriter-1.4.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407706c15

Comment 11 Fedora Update System 2024-08-24 01:52:16 UTC
FEDORA-2024-0407706c15 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407706c15 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407706c15

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-08-24 02:58:17 UTC
FEDORA-2024-7a1b1d1bc6 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7a1b1d1bc6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a1b1d1bc6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-08-25 01:27:19 UTC
FEDORA-2024-7a1b1d1bc6 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7a1b1d1bc6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a1b1d1bc6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-08-25 02:33:29 UTC
FEDORA-2024-0407706c15 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407706c15`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407706c15

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-08-26 02:23:20 UTC
FEDORA-2024-0407706c15 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407706c15`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407706c15

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-08-26 02:27:59 UTC
FEDORA-2024-7a1b1d1bc6 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7a1b1d1bc6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a1b1d1bc6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-09-03 03:40:27 UTC
FEDORA-2024-0407706c15 (rust-chrono-tz-0.9.0-1.fc39, rust-chrono-tz-build-0.3.0-1.fc39, and 8 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-09-03 05:49:31 UTC
FEDORA-2024-7a1b1d1bc6 (rust-chrono-tz-0.9.0-1.fc40, rust-chrono-tz-build-0.3.0-1.fc40, and 8 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.