Bug 2307325 - Review Request: rust-jiff - Date-time library that encourages you to jump into the pit of success
Summary: Review Request: rust-jiff - Date-time library that encourages you to jump int...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/jiff
Whiteboard:
Depends On: 2307083
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-08-22 16:33 UTC by Ben Beasley
Modified: 2024-09-03 05:49 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-24 12:34:44 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-08-22 16:33:28 UTC
Spec URL: https://music.fedorapeople.org/rust-jiff.spec
SRPM URL: https://music.fedorapeople.org/rust-jiff-0.1.8-1.fc40.src.rpm

Description:

A date-time library that encourages you to jump into the pit of success.
This library is heavily inspired by the Temporal project.

Fedora Account System Username: music

This is a new dependency for updating uv, https://src.fedoraproject.org/rpms/uv, to version 0.3.0.

Comment 1 Fedora Review Service 2024-08-22 16:46:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7935524
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307325-rust-jiff/fedora-rawhide-x86_64/07935524-rust-jiff/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Michel Lind 2024-08-22 18:58:09 UTC
chain-built with tabwriter to complete the review

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Unlicense OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Ben Beasley 2024-08-22 19:12:05 UTC
Thank you for the review!

I configured release monitoring, https://release-monitoring.org/project/374005/, and will request the dist-git repository once rust-tabwriter is unretired.

Comment 4 Ben Beasley 2024-08-23 12:21:12 UTC
Import delayed by FAS issues, https://pagure.io/releng/fedora-scm-requests/issue/65398, https://status.fedoraproject.org/

Comment 5 Fedora Admin user for bugzilla script actions 2024-08-23 19:13:33 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-jiff

Comment 6 Fedora Update System 2024-08-24 12:31:31 UTC
FEDORA-2024-5e4d314793 (rust-jiff-0.1.8-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5e4d314793

Comment 7 Fedora Update System 2024-08-24 12:34:44 UTC
FEDORA-2024-5e4d314793 (rust-jiff-0.1.8-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-08-24 19:49:37 UTC
FEDORA-2024-7a1b1d1bc6 (rust-chrono-tz-0.9.0-1.fc40, rust-chrono-tz-build-0.3.0-1.fc40, and 7 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a1b1d1bc6

Comment 9 Fedora Update System 2024-08-24 19:50:52 UTC
FEDORA-2024-0407706c15 (rust-chrono-tz-0.9.0-1.fc39, rust-chrono-tz-build-0.3.0-1.fc39, and 7 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407706c15

Comment 10 Fedora Update System 2024-08-25 01:27:21 UTC
FEDORA-2024-7a1b1d1bc6 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7a1b1d1bc6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a1b1d1bc6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-08-25 02:33:31 UTC
FEDORA-2024-0407706c15 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407706c15`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407706c15

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-08-26 02:23:22 UTC
FEDORA-2024-0407706c15 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407706c15`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407706c15

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-08-26 02:28:01 UTC
FEDORA-2024-7a1b1d1bc6 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7a1b1d1bc6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7a1b1d1bc6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-09-03 03:40:28 UTC
FEDORA-2024-0407706c15 (rust-chrono-tz-0.9.0-1.fc39, rust-chrono-tz-build-0.3.0-1.fc39, and 8 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-09-03 05:49:33 UTC
FEDORA-2024-7a1b1d1bc6 (rust-chrono-tz-0.9.0-1.fc40, rust-chrono-tz-build-0.3.0-1.fc40, and 8 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.