Bug 230768
| Summary: | dosbox 0.70 released | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
| Component: | dosbox | Assignee: | Andreas Bierfert <andreas.bierfert> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-04 22:42:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christopher Stone
2007-03-02 19:21:48 UTC
There are also some problems with the spec file: 1) --enable-shots is not a recognized configure option 2) dosbox should be configured with --enable-core-inline 3) you should use make install DESTDIR=$RPM_BUILD_ROOT (%makeinstall should be avoided whenever possible) Thanks for reporting, I will take a look at it now. 1) and 2) sound good to me. However what you say about %makeinstall is not how I think about it an in this case was taken by choice and not by accident... From the packaging guidelines page: http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works. I tested the make install DESTDIR=$RPM_BUILD_ROOT and it works fine, therefore %makeinstall should be avoided at all costs because it is a kludge. Please read the link above for more information. Thanks for the lesson ;) I still don't see the point anyway but you are right in current version (and actually in the 0.65) make install works and as you may see from the commits earlier I changed it so I hope you are happy :). Thanks again for submitting the bug. |