Bug 2308207

Summary:	Review Request: python-cmakedoc - Command-line tool to read CMake documentation
Product:	[Fedora] Fedora	Reporter:	Nicolas Fella <nicolas.fella>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	ngompa13: fedora-review?
Hardware:	All
OS:	Linux
URL:	https://pypi.org/project/cmakedoc
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Fella 2024-08-27 18:23:27 UTC

Spec URL: https://nicolasfella.de/python-cmakedoc.spec
SRPM URL: http://nicolasfella.de/python-cmakedoc-1.0.1-1.fc40.src.rpm
Description: CMakeDoc is a command-line tool to read CMake documentation.
It lets you search through CMake commands, modules, variables and properties.
Fedora Account System Username: nicolasfella

Comment 1 Neal Gompa 2024-08-27 18:26:56 UTC

Taking this review.

Comment 2 Fedora Review Service 2024-08-27 18:28:07 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7948240
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2308207-python-cmakedoc/fedora-rawhide-x86_64/07948240-python-cmakedoc/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2024-09-07 10:41:00 UTC

Overall, this package looks good, but there's one thing missing: "%license COPYING" in the files list to ensure we copy the license file into the package.

Comment 4 Nicolas Fella 2024-10-04 22:03:53 UTC

naming question: Given that this is more of an application/tool and https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming, shouldn't the name be just "cmakedoc"?

Comment 5 Neal Gompa 2025-01-15 19:28:16 UTC

(In reply to Nicolas Fella from comment #4)
> naming question: Given that this is more of an application/tool and
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_application_naming, shouldn't the name be just "cmakedoc"?

You certainly could, it doesn't seem to provide anything importable either.

Comment 6 Package Review 2026-01-16 00:45:23 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 7 Neal Gompa 2026-01-16 13:27:59 UTC

I'm still interested in reviewing this.

Comment 8 Neal Gompa 2026-01-16 13:28:39 UTC

Also it looks like the packaging spec and SRPM URLs are dead. :(