Spec URL: https://nicolasfella.de/python-cmakedoc.spec SRPM URL: http://nicolasfella.de/python-cmakedoc-1.0.1-1.fc40.src.rpm Description: CMakeDoc is a command-line tool to read CMake documentation. It lets you search through CMake commands, modules, variables and properties. Fedora Account System Username: nicolasfella
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7948240 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2308207-python-cmakedoc/fedora-rawhide-x86_64/07948240-python-cmakedoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Overall, this package looks good, but there's one thing missing: "%license COPYING" in the files list to ensure we copy the license file into the package.
naming question: Given that this is more of an application/tool and https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming, shouldn't the name be just "cmakedoc"?
(In reply to Nicolas Fella from comment #4) > naming question: Given that this is more of an application/tool and > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_application_naming, shouldn't the name be just "cmakedoc"? You certainly could, it doesn't seem to provide anything importable either.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
I'm still interested in reviewing this.
Also it looks like the packaging spec and SRPM URLs are dead. :(