Bug 2311656
| Summary: | Please branch and build yasm for EPEL 10 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Xavier Bachelot <xavier> |
| Component: | yasm | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel10 | CC: | dominik, gary.buhrmaster, nickc, sergio, suraj.ghimire7 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-23 15:35:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2303880, 2311553 | ||
|
Description
Xavier Bachelot
2024-09-11 14:57:22 UTC
Does it have to be yasm ? Yasm has been removed from RHEL-10. You should be able to use nasm in place of yasm without any difficulties. yeah we "talked" about this subject in #multimedia:fedoraproject.org just as reminder and in resume : x264 switched to nasm 7 years ago: https://code.videolan.org/videolan/x264/-/commit/d2b5f4873e2147452a723b61b14f030b2ee760a5 and the reason they did so is still valid: https://github.com/yasm/yasm/issues/101 if upstream is still preferring yasm, then this could be made conditional, e.g.: +%if 0%{?rhel} +BuildRequires: nasm +%else BuildRequires: yasm +%endif and - -DCMAKE_BUILD_TYPE=RelWithDebInfo + -DCMAKE_BUILD_TYPE=RelWithDebInfo %{?rhel:-DENABLE_NASM=yes} (In reply to Sergio Basto from comment #2) > if upstream is still preferring yasm, then this could be made conditional, > e.g.: > +%if 0%{?rhel} > +BuildRequires: nasm > +%else > BuildRequires: yasm > +%endif > > and > - -DCMAKE_BUILD_TYPE=RelWithDebInfo > + -DCMAKE_BUILD_TYPE=RelWithDebInfo %{?rhel:-DENABLE_NASM=yes} As I recall, at least for recent versions, aom will build using nasm if available if yasm is not available (if both are available, it chooses yasm), so only the first stanza is required (or just replace yasm with nasm for all?). |