Bug 2311656 - Please branch and build yasm for EPEL 10
Summary: Please branch and build yasm for EPEL 10
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: yasm
Version: epel10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: EPEL10Tracker 2311553
TreeView+ depends on / blocked
 
Reported: 2024-09-11 14:57 UTC by Xavier Bachelot
Modified: 2024-09-23 15:35 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-23 15:35:14 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Xavier Bachelot 2024-09-11 14:57:22 UTC
Hi,

Could you please branch and build yasm for EPEL 10 ?
It is needed to build another package.

Regards,
Xavier

Comment 1 Nick Clifton 2024-09-12 08:58:00 UTC
Does it have to be yasm ?

Yasm has been removed from RHEL-10.
You should be able to use nasm in place of yasm without any difficulties.

Comment 2 Sergio Basto 2024-09-12 22:01:19 UTC
yeah we "talked" about this subject in #multimedia:fedoraproject.org 
 
just as reminder and in resume : 

x264 switched to nasm 7 years ago: https://code.videolan.org/videolan/x264/-/commit/d2b5f4873e2147452a723b61b14f030b2ee760a5
and the reason they did so is still valid: https://github.com/yasm/yasm/issues/101

if upstream is still preferring yasm, then this could be made conditional, e.g.:
+%if 0%{?rhel}
+BuildRequires:    nasm
+%else
 BuildRequires:    yasm
+%endif

and
-     -DCMAKE_BUILD_TYPE=RelWithDebInfo
+     -DCMAKE_BUILD_TYPE=RelWithDebInfo %{?rhel:-DENABLE_NASM=yes}

Comment 3 Gary Buhrmaster 2024-09-15 19:12:19 UTC
(In reply to Sergio Basto from comment #2)

> if upstream is still preferring yasm, then this could be made conditional,
> e.g.:
> +%if 0%{?rhel}
> +BuildRequires:    nasm
> +%else
>  BuildRequires:    yasm
> +%endif
> 
> and
> -     -DCMAKE_BUILD_TYPE=RelWithDebInfo
> +     -DCMAKE_BUILD_TYPE=RelWithDebInfo %{?rhel:-DENABLE_NASM=yes}

As I recall, at least for recent versions, aom will build using nasm if available if yasm is not available (if both are available, it chooses yasm), so only the first stanza is required (or just replace yasm with nasm for all?).

Comment 4 Dominik 'Rathann' Mierzejewski 2024-09-19 19:55:54 UTC
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-2e1f824ab6


Note You need to log in before you can comment on or make changes to this bug.