Bug 2311885
| Summary: | rbd: disabling mirroring should fail if the the image is not in mirror disabled state | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat OpenShift Data Foundation | Reporter: | Rakshith <rar> |
| Component: | csi-driver | Assignee: | Rakshith <rar> |
| Status: | CLOSED ERRATA | QA Contact: | Sidhant Agrawal <sagrawal> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.17 | CC: | ebenahar, hnallurv, kramdoss, odf-bz-bot |
| Target Milestone: | --- | ||
| Target Release: | ODF 4.17.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 4.17.0-100 | Doc Type: | No Doc Update |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-10-30 14:35:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.17.0 Security, Enhancement, & Bug Fix Update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:8676 |
Description of problem (please be detailed as possible and provide log snippests): CephCSI had a bug which did not check for the image to be in mirror image disabled state after disabling mirroring on it. ``` ---------------------------------------------------------------------------- if info.GetState() == librbd.MirrorImageDisabling.String() { return fmt.Errorf("%w: image is in disabling state", ErrAborted) ---------------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ // error out if the image is not in disabled state. if info.GetState() != librbd.MirrorImageDisabled.String() { return fmt.Errorf("%w: image is in %q state, expected state %q", ErrAborted, info.GetState(), librbd.MirrorImageDisabled.String()) } ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ return nil ``` This bug was fixed in https://github.com/ceph/ceph-csi/pull/4832. Version of all relevant components (if applicable): 4.17 Does this issue impact your ability to continue to work with the product (please explain in detail what is the user impact)? No Is there any workaround available to the best of your knowledge? No Rate from 1 - 5 the complexity of the scenario you performed that caused this bug (1 - very simple, 5 - very complex)? The issue cannot be hit easily and has not been encountered. Validation Steps: Running few relocation and failover attempts with multiple rbd workloads should be enough to verify this BZ.