Bug 2312562

Summary: Review Request: rust-bitvec-nom2 - Bit level parsing for nom with bitvec
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/bitvec-nom2
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-04-29 00:45:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449    

Description Davide Cavalca 2024-09-16 14:08:17 UTC 
Spec URL: https://dcavalca.fedorapeople.org/review/rust-bitvec-nom2/rust-bitvec-nom2.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-bitvec-nom2/rust-bitvec-nom2-0.2.1-1.fc42.src.rpm

Description:
Bit level parsing for nom with bitvec.

Fedora Account System Username: dcavalca
Comment 1 Davide Cavalca 2024-09-16 14:08:19 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=123486848
Comment 2 Davide Cavalca 2024-09-16 14:09:01 UTC 
$ cat rust2rpm.toml
[tests]
run = ["none"]
comments = ["Tests fail to build"]
Comment 3 Fedora Review Service 2024-09-16 14:11:03 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8024304
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312562-rust-bitvec-nom2/fedora-rawhide-x86_64/08024304-rust-bitvec-nom2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 4 Fabio Valentini 2024-10-15 12:19:25 UTC 
It looks like this is a fork of a different crate (nom-bitvec?) and the test code just wasn't updated for the name change.

@tests/bitstream.rs
-use nom_bitvec::BSlice;
+use bitvec_nom2::BSlice;

This seems to be all that's necessary to fix them.
Comment 5 Fabio Valentini 2025-03-29 22:21:52 UTC 
Are you still interested in this package?
Comment 6 Package Review 2025-04-29 00:45:44 UTC 
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.