Bug 2312562 - Review Request: rust-bitvec-nom2 - Bit level parsing for nom with bitvec
Summary: Review Request: rust-bitvec-nom2 - Bit level parsing for nom with bitvec
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/bitvec-nom2
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-16 14:08 UTC by Davide Cavalca
Modified: 2024-10-15 12:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Davide Cavalca 2024-09-16 14:08:17 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-bitvec-nom2/rust-bitvec-nom2.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-bitvec-nom2/rust-bitvec-nom2-0.2.1-1.fc42.src.rpm

Description:
Bit level parsing for nom with bitvec.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-09-16 14:08:19 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=123486848

Comment 2 Davide Cavalca 2024-09-16 14:09:01 UTC
$ cat rust2rpm.toml
[tests]
run = ["none"]
comments = ["Tests fail to build"]

Comment 3 Fedora Review Service 2024-09-16 14:11:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8024304
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312562-rust-bitvec-nom2/fedora-rawhide-x86_64/08024304-rust-bitvec-nom2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-10-15 12:19:25 UTC
It looks like this is a fork of a different crate (nom-bitvec?) and the test code just wasn't updated for the name change.

@tests/bitstream.rs
-use nom_bitvec::BSlice;
+use bitvec_nom2::BSlice;

This seems to be all that's necessary to fix them.


Note You need to log in before you can comment on or make changes to this bug.