Bug 2315609

Summary: A request for building rust-atomic0.5 on Fedora 41 and 42
Product: [Fedora] Fedora Reporter: wojnilowicz <lukasz.wojnilowicz>
Component: rust-atomic0.5Assignee: Rust SIG <rust-sig>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, rust-sig
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rust-atomic0.5-0.5.3-2.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-09 00:16:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2315472    
Attachments:
Description Flags
cannot_build_rocket_0.5_with_atomic_0.6.txt none

Description wojnilowicz 2024-09-30 06:56:32 UTC
Hi, could you continue building rust-atomic0.5 on Fedora 41 and upwards? I need it for buidling rust-rocket. Currently they're seen as available only for F39 and F40 at https://src.fedoraproject.org/rpms/rust-atomic0.5

Reproducible: Always

Comment 1 Fabio Valentini 2024-09-30 10:25:16 UTC
I would really like not to have to add *back* compat packages that were already retired.

Would it be possible to port this package to atomic v0.6?

Comment 2 wojnilowicz 2024-09-30 13:36:24 UTC
(In reply to Fabio Valentini from comment #1)
> I would really like not to have to add *back* compat packages that were
> already retired.
> 
> Would it be possible to port this package to atomic v0.6?

It's already done for rocket 0.6 as seen at https://github.com/rwf2/Rocket/blob/master/core/lib/Cargo.toml Actually nothing is seen because this crate would not be a dependency anymore.

Rocket 0.6 is still unreleased though. I need rocket 0.5 for building ActivityWatch. Without it whole my work on the missing dependencies would be go for nothing.

I could retire it myself if you wish.

Comment 3 Fabio Valentini 2024-09-30 13:41:15 UTC
You can patch the dependency from 0.5 to 0.6 without needing to package a pre-release or waiting for a new release. It looks like the APIs between atomic 0.5 and 0.6 didn't change (much), so it should be as simple as patching rocket for bumping the atomic dependency 0.5 -> 0.6 when packaging it.

Comment 4 wojnilowicz 2024-09-30 13:45:42 UTC
Ok. I'll try to do that and come back with the results. Thanks for investigating.

Comment 5 wojnilowicz 2024-09-30 15:01:33 UTC
Created attachment 2049555 [details]
cannot_build_rocket_0.5_with_atomic_0.6.txt

I tried but failed (details in the attachment). I don't know rust, so I'm not sure how should I handle those errors. 
Is it easily fixable? If not, then wouldn't it be easier just to unretire rust-atomic0.5?

Comment 6 Fabio Valentini 2024-09-30 15:15:02 UTC
Hm, that error does look strange. atomic v0.6 *does* implement the NoUninit trait from bytemuck ...

I'll need to take a closer look later.

Comment 7 Fabio Valentini 2024-10-03 12:21:38 UTC
It does look like using atomic 0.6 here won't be easy.

I filed a request to unretire the atomic v0.5 compat package in f41 and f42:
https://pagure.io/releng/issue/12375

Comment 8 Fedora Update System 2024-10-03 15:04:26 UTC
FEDORA-2024-ec95e0a8df (rust-atomic0.5-0.5.3-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ec95e0a8df

Comment 9 Fedora Update System 2024-10-04 02:56:58 UTC
FEDORA-2024-ec95e0a8df has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ec95e0a8df \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ec95e0a8df

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-10-09 00:16:39 UTC
FEDORA-2024-ec95e0a8df (rust-atomic0.5-0.5.3-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.