Bug 2315472 - Review Request: rust-rocket - Web framework with a focus on usability, security, extensibility, and speed
Summary: Review Request: rust-rocket - Web framework with a focus on usability, securi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/rocket
Whiteboard:
Depends On: 2315609 2315611
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-28 16:33 UTC by wojnilowicz
Modified: 2024-10-15 17:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-10-15 17:52:08 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description wojnilowicz 2024-09-28 16:33:32 UTC
Spec URL: https://wojnilowicz.fedorapeople.org/rust-rocket.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-rocket-0.5.1-1.fc39.src.rpm

rust2rpm.toml: https://wojnilowicz.fedorapeople.org/rocket/rust2rpm.toml

Description:
Web framework with a focus on usability, security, extensibility, and
speed.

Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and rocket package is in its requirements chain. The chain is as follows: aw-server-rust->rocket.

Comment 1 wojnilowicz 2024-09-29 06:15:16 UTC
[fedora-review-service-build]

Comment 2 Fedora Review Service 2024-09-30 05:54:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8091454
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315472-rust-rocket/fedora-rawhide-x86_64/08091454-rust-rocket/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 wojnilowicz 2024-10-09 15:58:28 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-10-09 16:32:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8123129
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315472-rust-rocket/fedora-rawhide-x86_64/08123129-rust-rocket/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2024-10-15 13:49:02 UTC
Looks good to me! Very simple package. I would have expected worse from an entire web framework :)

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fedora Admin user for bugzilla script actions 2024-10-15 17:06:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rocket

Comment 7 wojnilowicz 2024-10-15 17:20:55 UTC
Thank you for the review, and yeah, this looks simple compared to the aw-server-rust that builds upon it :)

Comment 8 Fedora Update System 2024-10-15 17:45:29 UTC
FEDORA-2024-5e73fa28f4 (rust-rocket-0.5.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5e73fa28f4

Comment 9 Fedora Update System 2024-10-15 17:52:08 UTC
FEDORA-2024-5e73fa28f4 (rust-rocket-0.5.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.