Bug 2316689
| Summary: | Review Request: rust-actix-cors - Cross-Origin Resource Sharing (CORS) controls for Actix Web | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/actix-cors | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-04-29 00:45:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Davide Cavalca
2024-10-05 15:57:47 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=124420228 $ cat rust2rpm.toml [scripts] # Fails to build prep.pre = ["rm examples/cors.rs"] [tests] run = ["none"] comments = ["Tests fail to build"] Copr build: https://copr.fedorainfracloud.org/coprs/build/8110341 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2316689-rust-actix-cors/fedora-rawhide-x86_64/08110341-rust-actix-cors/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The tests are easy to fix, it's just missing dependencies. Not sure how upstream handles this ... ```patch diff --git a/Cargo.toml b/Cargo.toml index b81c8ae..098ce49 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -62,5 +62,16 @@ version = "1" [dependencies.smallvec] version = "1" +[dev-dependencies.actix-web] +version = "4" +default-features = false +features = ["macros"] + +[dev-dependencies.env_logger] +version = "0.11" + +[dev-dependencies.regex] +version = "1" + [features] draft-private-network-access = [] ``` (In reply to Davide Cavalca from comment #0) > Spec URL: > https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors.spec > SRPM URL: > https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors-0.7. https://incrediboxsprunki.org/ > 0-1.fc42.src.rpm > > Description: > Cross-Origin Resource Sharing (CORS) controls for Actix Web. > > Fedora Account System Username: dcavalca Below is an example review request you might find useful for submitting feedback or understanding the library’s capabilities. This comment was flagged as spam, view the edit history to see the original text if required. spam spam lovely spam This comment was flagged as spam, view the edit history to see the original text if required. Are you still interested in this package? This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |