Bug 2316689 - Review Request: rust-actix-cors - Cross-Origin Resource Sharing (CORS) controls for Actix Web
Summary: Review Request: rust-actix-cors - Cross-Origin Resource Sharing (CORS) contro...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/actix-cors
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2024-10-05 15:57 UTC by Davide Cavalca
Modified: 2025-04-29 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-29 00:45:57 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2024-10-05 15:57:47 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors-0.7.0-1.fc42.src.rpm

Description:
Cross-Origin Resource Sharing (CORS) controls for Actix Web.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-10-05 15:57:50 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=124420228

Comment 2 Davide Cavalca 2024-10-05 15:58:16 UTC
$ cat rust2rpm.toml 
[scripts]
# Fails to build
prep.pre = ["rm examples/cors.rs"]

[tests]
run = ["none"]
comments = ["Tests fail to build"]

Comment 3 Fedora Review Service 2024-10-05 16:47:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8110341
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2316689-rust-actix-cors/fedora-rawhide-x86_64/08110341-rust-actix-cors/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-10-17 09:57:38 UTC
The tests are easy to fix, it's just missing dependencies. Not sure how upstream handles this ...

```patch
diff --git a/Cargo.toml b/Cargo.toml
index b81c8ae..098ce49 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -62,5 +62,16 @@ version = "1"
 [dependencies.smallvec]
 version = "1"
 
+[dev-dependencies.actix-web]
+version = "4"
+default-features = false
+features = ["macros"]
+
+[dev-dependencies.env_logger]
+version = "0.11"
+
+[dev-dependencies.regex]
+version = "1"
+
 [features]
 draft-private-network-access = []
```

Comment 5 otiscavin 2024-12-02 03:33:43 UTC Comment hidden (spam)
Comment 6 Lore Theofilo 2024-12-11 07:32:01 UTC Comment hidden (spam)
Comment 7 Fabio Valentini 2024-12-12 00:02:31 UTC
spam spam lovely spam

Comment 8 Jack 2024-12-27 07:54:36 UTC Comment hidden (spam)
Comment 9 Fabio Valentini 2025-03-29 22:26:06 UTC
Are you still interested in this package?

Comment 10 Package Review 2025-04-29 00:45:57 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.