Bug 2317263
| Summary: | Review Request: rust-proc-macro-error2 - Almost drop-in replacement to panics in proc-macros | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | wojnilowicz <lukasz.wojnilowicz> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | lukasz.wojnilowicz, package-review |
| Target Milestone: | --- | Flags: | lukasz.wojnilowicz:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/proc-macro-error2 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-12-06 13:03:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2317261 | ||
| Bug Blocks: | 2311317 | ||
|
Description
Fabio Valentini
2024-10-08 16:26:47 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8119082 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317263-rust-proc-macro-error2/fedora-rawhide-x86_64/08119082-rust-proc-macro-error2/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (justified not running ok.rs with unavailable test_crate) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === BTW, if you have time, then please review https://bugzilla.redhat.com/show_bug.cgi?id=2327650 Thank you for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-proc-macro-error2 FEDORA-2024-2f883cf793 (rust-getset-0.1.3-1.fc42 and rust-proc-macro-error2-2.0.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2f883cf793 FEDORA-2024-2f883cf793 (rust-getset-0.1.3-1.fc42 and rust-proc-macro-error2-2.0.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |