Bug 2317261 - Review Request: rust-proc-macro-error-attr2 - Attribute macro for the proc-macro-error2 crate
Summary: Review Request: rust-proc-macro-error-attr2 - Attribute macro for the proc-ma...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/proc-macro-e...
Whiteboard:
Depends On:
Blocks: 2317263
TreeView+ depends on / blocked
 
Reported: 2024-10-08 16:21 UTC by Fabio Valentini
Modified: 2024-11-04 11:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-11-04 11:10:41 UTC
Type: ---
Embargoed:
lukasz.wojnilowicz: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-10-08 16:21:02 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-proc-macro-error-attr2.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-proc-macro-error-attr2-2.0.0-1.fc41.src.rpm

Description:
Attribute macro for the proc-macro-error2 crate.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-10-08 16:21:04 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=124575646

Comment 2 Fedora Review Service 2024-10-08 16:30:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8119076
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317261-rust-proc-macro-error-attr2/fedora-rawhide-x86_64/08119076-rust-proc-macro-error-attr2/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 wojnilowicz 2024-10-24 14:53:24 UTC
===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (no tests available)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

BTW, if you have time, then please review https://bugzilla.redhat.com/show_bug.cgi?id=2321515

Comment 4 Fabio Valentini 2024-11-04 10:46:03 UTC
Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2024-11-04 10:47:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-proc-macro-error-attr2

Comment 6 Fabio Valentini 2024-11-04 11:10:41 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-00f2af31f8


Note You need to log in before you can comment on or make changes to this bug.