Bug 2317835
| Summary: | Review Request: pie - PHP Installer for Extensions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, shawn |
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/php/pie | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-01-18 01:24:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Remi Collet
2024-10-10 13:24:03 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8126154 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08126154-pie/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Not a valid SPDX expression 'BSD-3-Clause and MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://rpms.remirepo.net/temp/pie.spec SRPM URL: https://rpms.remirepo.net/temp/pie-0.1.0-2.fedora.src.rpm Created attachment 2054342 [details]
The .spec file difference from Copr build 8126154 to 8189133
Copr build: https://copr.fedorainfracloud.org/coprs/build/8189133 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08189133-pie/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://rpms.remirepo.net/temp/pie.spec SRPM URL: https://rpms.remirepo.net/temp/pie-0.2.0-1.fedora.src.rpm Created attachment 2058638 [details]
The .spec file difference from Copr build 8189133 to 8279578
Copr build: https://copr.fedorainfracloud.org/coprs/build/8279578 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08279578-pie/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://rpms.remirepo.net/temp/pie.spec SRPM URL: https://rpms.remirepo.net/temp/pie-0.2.0-2.fedora.src.rpm Created attachment 2062251 [details]
The .spec file difference from Copr build 8279578 to 8388393
Copr build: https://copr.fedorainfracloud.org/coprs/build/8388393 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08388393-pie/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://rpms.remirepo.net/temp/pie.spec SRPM URL: https://rpms.remirepo.net/temp/pie-0.3.0-1.fedora.src.rpm Created attachment 2063732 [details]
The .spec file difference from Copr build 8388393 to 8443585
Copr build: https://copr.fedorainfracloud.org/coprs/build/8443585 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08443585-pie/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2063786 [details]
fedora-review.txt
[!]: %check is present and all tests pass. Approving because tests can be added at a later point as seen fit by packager The Pagure repository was created at https://src.fedoraproject.org/rpms/pie Thanks for the review! SCM requests https://pagure.io/releng/fedora-scm-requests/issue/71194 https://pagure.io/releng/fedora-scm-requests/issue/71195 https://pagure.io/releng/fedora-scm-requests/issue/71196 https://pagure.io/releng/fedora-scm-requests/issue/71197 FEDORA-2024-3844b821e8 (pie-0.3.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3844b821e8 FEDORA-2024-f707ddaaf7 (pie-0.3.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f707ddaaf7 FEDORA-EPEL-2024-caa628ee2f (pie-0.3.0-1.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-caa628ee2f > Approving because tests can be added at a later point as seen fit by packager For now, most tests are online tests requiring the internet to send requests to packagist :( So doesn't seem to be very useful... Notice: imported without not yet available composer-generators waiting for review as bug #2317977 FEDORA-2024-f707ddaaf7 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f707ddaaf7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f707ddaaf7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-3844b821e8 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3844b821e8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3844b821e8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-caa628ee2f has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-caa628ee2f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-8396c1eb1b has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-8396c1eb1b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-8396c1eb1b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-c9952b2f4f has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c9952b2f4f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-ace6c64f7f has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ace6c64f7f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ace6c64f7f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-c178856ed7 has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c178856ed7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-b0af155579 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b0af155579 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b0af155579 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-18a829e1cc has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-18a829e1cc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-18a829e1cc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-18a829e1cc (pie-0.5.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-c178856ed7 (pie-0.5.0-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-b0af155579 (pie-0.5.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |