Bug 2317835 - Review Request: pie - PHP Installer for Extensions
Summary: Review Request: pie - PHP Installer for Extensions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/php/pie
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-10-10 13:24 UTC by Remi Collet
Modified: 2025-01-18 03:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-18 01:24:11 UTC
Type: ---
Embargoed:
shawn: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8126154 to 8189133 (8.03 KB, patch)
2024-10-30 11:01 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8189133 to 8279578 (4.35 KB, patch)
2024-11-19 10:03 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8279578 to 8388393 (975 bytes, patch)
2024-12-13 07:09 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8388393 to 8443585 (3.66 KB, patch)
2024-12-24 08:42 UTC, Fedora Review Service
no flags Details | Diff
fedora-review.txt (15.64 KB, text/plain)
2024-12-24 18:30 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2024-10-10 13:24:03 UTC
Spec URL: https://rpms.remirepo.net/temp/pie.spec
SRPM URL: https://rpms.remirepo.net/temp/pie-0.1.0-1.fedora.src.rpm
Description: 
PIE (PHP Installer for Extensions).

PIE can install an extension to any installed PHP version.

A list of extensions that support PIE can be found on
https://packagist.org/extensions.

Documentation: /usr/share/doc/pie/docs/usage.md


Fedora Account System Username: remi

Comment 1 Fedora Review Service 2024-10-10 13:30:43 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8126154
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08126154-pie/fedora-review/review.txt

Found issues:

- License file LICENSE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
- Not a valid SPDX expression 'BSD-3-Clause and MIT'.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2024-10-30 11:01:33 UTC
Created attachment 2054342 [details]
The .spec file difference from Copr build 8126154 to 8189133

Comment 4 Fedora Review Service 2024-10-30 11:01:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8189133
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08189133-pie/fedora-review/review.txt

Found issues:

- License file LICENSE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2024-11-19 10:03:06 UTC
Created attachment 2058638 [details]
The .spec file difference from Copr build 8189133 to 8279578

Comment 7 Fedora Review Service 2024-11-19 10:03:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8279578
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08279578-pie/fedora-review/review.txt

Found issues:

- License file LICENSE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Fedora Review Service 2024-12-13 07:09:06 UTC
Created attachment 2062251 [details]
The .spec file difference from Copr build 8279578 to 8388393

Comment 10 Fedora Review Service 2024-12-13 07:09:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8388393
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08388393-pie/fedora-review/review.txt

Found issues:

- License file LICENSE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Fedora Review Service 2024-12-24 08:42:28 UTC
Created attachment 2063732 [details]
The .spec file difference from Copr build 8388393 to 8443585

Comment 13 Fedora Review Service 2024-12-24 08:42:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8443585
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317835-pie/fedora-rawhide-x86_64/08443585-pie/fedora-review/review.txt

Found issues:

- License file LICENSE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 14 Shawn Iwinski 2024-12-24 18:30:01 UTC
Created attachment 2063786 [details]
fedora-review.txt

Comment 15 Shawn Iwinski 2024-12-24 18:31:06 UTC
[!]: %check is present and all tests pass.

Approving because tests can be added at a later point as seen fit by packager

Comment 16 Fedora Admin user for bugzilla script actions 2024-12-30 08:32:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/pie

Comment 18 Fedora Update System 2024-12-30 08:51:00 UTC
FEDORA-2024-3844b821e8 (pie-0.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3844b821e8

Comment 19 Fedora Update System 2024-12-30 08:51:01 UTC
FEDORA-2024-f707ddaaf7 (pie-0.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f707ddaaf7

Comment 20 Fedora Update System 2024-12-30 08:51:01 UTC
FEDORA-EPEL-2024-caa628ee2f (pie-0.3.0-1.el10_0) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-caa628ee2f

Comment 21 Remi Collet 2024-12-30 09:05:06 UTC
> Approving because tests can be added at a later point as seen fit by packager

For now, most tests are online tests requiring the internet to send requests to packagist :(
So doesn't seem to be very useful...


Notice: imported without not yet available composer-generators waiting for review as bug #2317977

Comment 22 Fedora Update System 2024-12-31 02:15:35 UTC
FEDORA-2024-f707ddaaf7 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f707ddaaf7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f707ddaaf7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 23 Fedora Update System 2024-12-31 02:37:27 UTC
FEDORA-2024-3844b821e8 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3844b821e8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3844b821e8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 Fedora Update System 2024-12-31 03:32:16 UTC
FEDORA-EPEL-2024-caa628ee2f has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-caa628ee2f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 25 Fedora Update System 2025-01-03 03:57:48 UTC
FEDORA-2025-8396c1eb1b has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-8396c1eb1b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-8396c1eb1b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 26 Fedora Update System 2025-01-03 04:53:04 UTC
FEDORA-EPEL-2025-c9952b2f4f has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c9952b2f4f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 27 Fedora Update System 2025-01-03 05:03:32 UTC
FEDORA-2025-ace6c64f7f has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ace6c64f7f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ace6c64f7f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 28 Fedora Update System 2025-01-10 02:11:08 UTC
FEDORA-EPEL-2025-c178856ed7 has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c178856ed7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 29 Fedora Update System 2025-01-10 03:11:54 UTC
FEDORA-2025-b0af155579 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b0af155579 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b0af155579

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 30 Fedora Update System 2025-01-10 03:36:31 UTC
FEDORA-2025-18a829e1cc has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-18a829e1cc \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-18a829e1cc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 31 Fedora Update System 2025-01-18 01:24:11 UTC
FEDORA-2025-18a829e1cc (pie-0.5.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 32 Fedora Update System 2025-01-18 02:01:56 UTC
FEDORA-EPEL-2025-c178856ed7 (pie-0.5.0-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 33 Fedora Update System 2025-01-18 03:04:32 UTC
FEDORA-2025-b0af155579 (pie-0.5.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.