Bug 2318048
| Summary: | Review Request: rust-serial-unix - Serial port implementation for Unix | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | solomoncyj |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 41 | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-12-06 02:52:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2318054, 2318059 | ||
| Bug Blocks: | 2321312 | ||
|
Description
solomoncyj
2024-10-11 15:12:55 UTC
Two things: 1. This is a library-only package. It doesn't look like it was generated by rust2rpm? It looks like it was generated from a checkout of your own (?) GitHub fork, and not from the sources on crates.io (which is a MUST for library crates). You MUST generate the spec file with "rust2rpm serial-unix", not from local sources. 2. This project is *really old* (last updated over 7 years ago). Are you *absolutely sure* you need it for what you're working on? 1. rust2rpm *will not* work on the crate from crates.io due to the path dependency
2. ``` cargo tree -i serial-unix
serial-unix v0.4.0
└── serial v0.4.0
└── portable-pty v0.8.1
└── linutil_tui v24.9.28 (/home/solomoncyj/Downloads/linutil/tui)
```
> 1. rust2rpm *will not* work on the crate from crates.io due to the path dependency Well ... then patch it? "rust2rpm -p serial-unix", remove "path = ...", done. There's no "if I don't feel like it" excpetion to the "MUST be from crates.io sources" rule. > 2. ``` cargo tree -i serial-unix *sigh* ok, it looks like it's a hard dependency, but I wonder why anybody would need this. Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08129822-rust-serial-unix/rust-serial-unix.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08129822-rust-serial-unix/rust-serial-unix-0.4.0-1.fc40.src.rpm Description: Routines for safe string operations Fedora Account System Username: solomoncyj I don't have time to continue with this review, so I'm marking it as "not taken" so it can be picked up by somebody else. |