Bug 2318048 - Review Request: rust-serial-unix - Serial port implementation for Unix
Summary: Review Request: rust-serial-unix - Serial port implementation for Unix
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 41
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2318054 2318059
Blocks: 2321312
TreeView+ depends on / blocked
 
Reported: 2024-10-11 15:12 UTC by solomoncyj
Modified: 2024-12-06 02:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-06 02:52:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Fabio Valentini 2024-10-11 15:18:25 UTC
Two things:

1. This is a library-only package. It doesn't look like it was generated by rust2rpm? It looks like it was generated from a checkout of your own (?) GitHub fork, and not from the sources on crates.io (which is a MUST for library crates). You MUST generate the spec file with "rust2rpm serial-unix", not from local sources.

2. This project is *really old* (last updated over 7 years ago). Are you *absolutely sure* you need it for what you're working on?

Comment 2 solomoncyj 2024-10-11 15:45:08 UTC
1. rust2rpm *will not* work on the crate from crates.io due to the  path dependency
2. ``` cargo tree -i serial-unix
serial-unix v0.4.0
└── serial v0.4.0
    └── portable-pty v0.8.1
        └── linutil_tui v24.9.28 (/home/solomoncyj/Downloads/linutil/tui)
```

Comment 3 Fabio Valentini 2024-10-11 16:05:28 UTC
> 1. rust2rpm *will not* work on the crate from crates.io due to the  path dependency

Well ... then patch it? "rust2rpm -p serial-unix", remove "path = ...", done.
There's no "if I don't feel like it" excpetion to the "MUST be from crates.io sources" rule.

> 2. ``` cargo tree -i serial-unix

*sigh* ok, it looks like it's a hard dependency, but I wonder why anybody would need this.

Comment 5 Fabio Valentini 2024-10-20 10:51:40 UTC
I don't have time to continue with this review, so I'm marking it as "not taken" so it can be picked up by somebody else.


Note You need to log in before you can comment on or make changes to this bug.