Bug 2318051
| Summary: | Review Request: rust-tree-sitter-language - Tree-sitter Language type, used by the library and by language implementations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | solomoncyj |
| Component: | Package Review | Assignee: | Cristian Le <fedora> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 41 | CC: | decathorpe, fedora, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | fedora:
fedora-review?
|
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/tree-sitter-language | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-10-25 05:41:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
solomoncyj
2024-10-11 15:18:51 UTC
> # FIXME: no license files detected
You need to actually fix this, it's not optional.
upstream repo contains one, but not in crates.io. switching upstream Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08129777-rust-tree-sitter-language/rust-tree-sitter-language.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08129777-rust-tree-sitter-language/rust-tree-sitter-language-0.23.1-1.fc40.src.rpm Description: Tree-sitter Language type, used by the library and by language implementations Fedora Account System Username: solomoncyj (In reply to solomoncyj from comment #2) > upstream repo contains one, but not in crates.io. switching upstream No, this is not the correct way to handle this situation, you MUST use the sources from crates.io. You can include the license file from the GitHub repo as a separate file. Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08131411-rust-tree-sitter-language/rust-tree-sitter-language.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40-x86_64/08131411-rust-tree-sitter-language/rust-tree-sitter-language-0.1.2-1.fc40.src.rpm Description: Tree-sitter Language type, used by the library and by language implementations Fedora Account System Username: solomoncyj The way the upstream license file is added here is not quite correct. For example, you can take a look at https://bugzilla.redhat.com/show_bug.cgi?id=2312634#c0 for how to handle additional license files, and ideally, also link the upstrema issue / PR that was filed to add the missing files. (In reply to Fabio Valentini from comment #7) > The way the upstream license file is added here is not quite correct. > > For example, you can take a look at > https://bugzilla.redhat.com/show_bug.cgi?id=2312634#c0 for how to handle > additional license files, and ideally, also link the upstrema issue / PR > that was filed to add the missing files. https://github.com/tree-sitter/tree-sitter/pull/3775 https://github.com/tree-sitter/tree-sitter/issues/3773 they were very insistent on not coping the file Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-x86_64/08145375-rust-tree-sitter-language/rust-tree-sitter-language.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-x86_64/08145375-rust-tree-sitter-language/rust-tree-sitter-language-0.1.2-1.fc42.src.rpm Description: Tree-sitter Language type, used by the library and by language implementations Fedora Account System Username: solomoncyj Copr build: https://copr.fedorainfracloud.org/coprs/build/8145378 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2318051-rust-tree-sitter-language/fedora-rawhide-x86_64/08145378-rust-tree-sitter-language/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I don't have time to continue with this review, so I'm marking it as "not taken" so it can be picked up by somebody else. Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-aarch64/08164725-rust-tree-sitter-language/rust-tree-sitter-language.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-rawhide-aarch64/08164725-rust-tree-sitter-language/rust-tree-sitter-language-0.1.2-1.fc42.src.rpm Description: Tree-sitter Language type, used by the library and by language implementations Fedora Account System Username: solomoncyj Only 1 issue, please change the reference of the Source2 from `master` to the closest tag (seems to be `v0.24.3` right now). Reasoning is that upstream frequently updates the copyright section and the files can quickly be mismatched. Alternatively you can copy the license locally instead of pointing it to an url. Other than that lgtm > Alternatively you can copy the license locally instead of pointing it to an url.
This is not allowed. Just use the file from the commit or tag closest to the published release.
super seeded by https://bugzilla.redhat.com/show_bug.cgi?id=2321682 *** This bug has been marked as a duplicate of bug 2321682 *** |