Bug 2312634 - Review Request: rust-asn1-rs-impl - Implementation details for the asn1-rs crate
Summary: Review Request: rust-asn1-rs-impl - Implementation details for the asn1-rs crate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/asn1-rs-impl
Whiteboard:
Depends On:
Blocks: rust-asn1-rs
TreeView+ depends on / blocked
 
Reported: 2024-09-16 19:37 UTC by Davide Cavalca
Modified: 2024-10-18 16:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-10-18 16:04:06 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-09-16 19:37:59 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs-impl/rust-asn1-rs-impl.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs-impl/rust-asn1-rs-impl-0.2.0-1.fc42.src.rpm

Description:
Implementation details for the `asn1-rs` crate.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-09-16 19:38:02 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=123502302

Comment 2 Davide Cavalca 2024-09-16 19:38:31 UTC
$ cat rust2rpm.toml 
[package]
extra-sources = [
  { "number" = 2, "file" = "https://github.com/rusticata/asn1-rs/raw/8750624225a91258e1f771558765b3dafc2c6830/LICENSE-APACHE", "comments" = ["https://github.com/rusticata/asn1-rs/commit/8750624225a91258e1f771558765b3dafc2c6830"] },
  { "number" = 3, "file" = "https://github.com/rusticata/asn1-rs/raw/8750624225a91258e1f771558765b3dafc2c6830/LICENSE-MIT", "comments" = ["https://github.com/rusticata/asn1-rs/commit/8750624225a91258e1f771558765b3dafc2c6830"] },
]

[scripts]
prep.pre = [
  "cp -p %SOURCE2 %SOURCE3 ."
]

Comment 3 Fedora Review Service 2024-09-16 19:43:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8025082
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312634-rust-asn1-rs-impl/fedora-rawhide-x86_64/08025082-rust-asn1-rs-impl/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-10-15 12:31:44 UTC
Thanks, looks good to me.
The license files have been added in git bit not released yet - can you link to the issue and / or PR?

https://github.com/rusticata/asn1-rs/issues/37
https://github.com/rusticata/asn1-rs/pull/38

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files (manually included from upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2024-10-18 15:45:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-asn1-rs-impl

Comment 6 Fedora Update System 2024-10-18 15:59:08 UTC
FEDORA-2024-6502654e18 (rust-asn1-rs-impl-0.2.0-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6502654e18

Comment 7 Fedora Update System 2024-10-18 16:04:06 UTC
FEDORA-2024-6502654e18 (rust-asn1-rs-impl-0.2.0-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.