Bug 2318062
| Summary: | Review Request: rust-ansi-to-tui - Library to convert ansi color coded text into ratatui::text::Text type from ratatui library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | solomoncyj |
| Component: | Package Review | Assignee: | Cristian Le <fedora> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 41 | CC: | fedora, package-review |
| Target Milestone: | --- | Flags: | fedora:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-05-21 00:27:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2310209 | ||
|
Description
solomoncyj
2024-10-11 15:39:19 UTC
The link is 404ed, but I am giving some preliminary comments based on your current GH repo status. A few things to change:
- Don't change the description inside of `Cargo.toml`
- The rpm description should be fine as it was
- The summary seems grammatically incomplete. Maybe add a `into ratatui` or `for ratatui`
- `criterion` is something you will have to constantly patch. Try using something like:
```
[requires]
build = [
"tomcli",
]
[scripts.prep]
post = [
"# Do not depend on criterion; it is needed only for benchmarks.",
"tomcli set Cargo.toml del dev-dependencies.criterion",
]
```
- There are a few unnecessary files being included in the `devel` package which would be nice to have removed: `flake.*`
You can just add an additional `rm` line in the `scripts.prep.post`
|